Compare commits
175 Commits
Task_1_-_S
...
ethan-stac
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d8edc6d3fe | ||
|
|
5682974f9d | ||
|
|
6f85d7642d | ||
|
|
13de832586 | ||
|
|
5c661c2e24 | ||
|
|
5f40d83e66 | ||
|
|
4f84a83611 | ||
|
|
c74a8c55aa | ||
|
|
c670c29e47 | ||
|
|
ea2725f606 | ||
|
|
af7f2ba873 | ||
|
|
3ef5264b6e | ||
|
|
605050e38d | ||
|
6225a2eb8b
|
|||
|
aedb72246b
|
|||
|
e1f0258f8e
|
|||
|
|
eed4ce5130 | ||
|
8567434231
|
|||
| e76712d3fd | |||
|
|
8f82f9d747 | ||
|
|
9ee29ac40a | ||
|
2566948a32
|
|||
| 222aeff90f | |||
|
|
ea3b3594ea | ||
|
|
6b1dbdd34f | ||
|
|
7daf4fb079 | ||
|
|
a7f1d519da | ||
|
|
0f1bce2e88 | ||
|
|
f4c900e56c | ||
|
|
82d45880f7 | ||
|
|
1c757ecdfe | ||
|
|
6a1d10a19b | ||
|
|
0e50603eef | ||
|
|
7947ac78e8 | ||
|
|
4b0d0a51f0 | ||
|
|
eff0837fdc | ||
|
|
9b82947beb | ||
|
|
5e2e7199f2 | ||
|
|
bbe41e178d | ||
|
|
e4036c715f | ||
|
|
3a46e0f73a | ||
|
|
8821851459 | ||
|
|
1a2ff35231 | ||
|
|
79b3b8fda7 | ||
|
f5e498e0a9
|
|||
| d02b956221 | |||
|
|
927c376d02 | ||
|
|
fa2fb4a711 | ||
|
|
31ea215805 | ||
|
e7cb16b301
|
|||
|
|
9549ca28e5 | ||
|
|
b1c5819469 | ||
|
|
287130ca7b | ||
|
|
4f586bb4da | ||
|
|
d890c2353e | ||
|
|
eb4f23c290 | ||
|
|
26de38cdba | ||
|
|
6e59e8c9f3 | ||
|
|
30e49846b5 | ||
|
005791edd2
|
|||
|
8bcd0a467c
|
|||
|
dd979f34c8
|
|||
|
ca9d23edf9
|
|||
|
|
d878dbc132 | ||
|
|
b0400693ae | ||
|
|
3418425f20 | ||
|
59e7a64f8e
|
|||
|
cf4bf90cbb
|
|||
|
9a6abab95e
|
|||
|
44f6a85163
|
|||
|
83e044cf68
|
|||
|
|
a69b9c808e | ||
|
|
7d9900c6d8 | ||
|
|
72afecfbda | ||
|
|
9e692ced9e | ||
|
|
f194fa1fa8 | ||
|
|
e8713e26c6 | ||
|
|
47c3657b65 | ||
|
|
4eafdf10ba | ||
|
|
14a4841772 | ||
|
|
52fdd47e0c | ||
|
|
049fc5559c | ||
|
|
98a5818406 | ||
|
18c884234d
|
|||
|
|
5b1e4b561b | ||
|
|
b8d358ecb2 | ||
|
|
8b2fc86b51 | ||
|
|
324301e7b3 | ||
|
|
0ac46db2e4 | ||
|
|
795d81b7ad | ||
|
|
6018c0f6ec | ||
|
|
f0dae74cf3 | ||
|
|
a165107f5f | ||
|
|
b37f205334 | ||
|
|
1bfd73b202 | ||
|
7778e05aa4
|
|||
|
|
115c650c55 | ||
|
|
5ed999bc9c | ||
|
|
e40794e672 | ||
|
|
a19f02fad7 | ||
|
|
8912ef4660 | ||
|
|
18694d7b62 | ||
|
|
2a1cc3c361 | ||
|
|
3cfbe198e0 | ||
|
|
75bd3fbde0 | ||
|
|
b866fa88cd | ||
|
|
a80084e907 | ||
|
|
5424276603 | ||
|
|
b64434fb9d | ||
|
|
92e93b8060 | ||
|
|
5bd94894e0 | ||
|
|
5bbe7a03c0 | ||
|
|
b112824a64 | ||
|
|
dca9d8f5a3 | ||
|
|
a8676f2e09 | ||
|
|
26e38be761 | ||
|
6ed1ccd21e
|
|||
|
84fe637c7e
|
|||
|
d95894085b
|
|||
|
fde70dcf59
|
|||
|
7349b4e66f
|
|||
|
ec8547aec9
|
|||
|
ddcd59fdf8
|
|||
|
|
ed09e0b08e | ||
|
|
39018419cd | ||
|
|
6a3cf67d33 | ||
|
|
2bfde66d22 | ||
|
|
273fb48b31 | ||
|
|
26ae7ac02e | ||
|
|
1ca9d09512 | ||
|
|
b2764cfa0c | ||
|
|
4020a140d2 | ||
|
|
87dd84a9b9 | ||
|
|
014642c789 | ||
|
|
dfa42b9d25 | ||
|
|
1a4afc9ec7 | ||
|
|
5535cbae24 | ||
|
|
f685086d05 | ||
|
|
2fefdef605 | ||
|
|
fcb7e9e441 | ||
|
|
ab716de0a6 | ||
|
|
91cef4d650 | ||
|
|
b0c1923d44 | ||
|
|
5aac37d167 | ||
|
|
02fff62ca2 | ||
|
|
f4290c31f3 | ||
|
|
01933cb5de | ||
|
|
b3e23eb1cc | ||
|
|
421f2c1206 | ||
|
|
e9c4061531 | ||
|
|
2dccd87a76 | ||
|
|
b4c41b0a6a | ||
|
|
2a890d5bd2 | ||
|
|
6c6ce77824 | ||
|
|
f8e529e877 | ||
|
|
2a9ab5ec97 | ||
|
|
4c27aa0203 | ||
|
|
5e2342fad7 | ||
|
|
0d057da3dc | ||
|
|
79f6a8e808 | ||
|
|
3a258cf064 | ||
|
|
e718159ed8 | ||
|
|
ade8faf0f4 | ||
|
|
6f9c911ebe | ||
|
|
62d2cb54e5 | ||
|
|
92c681ff02 | ||
|
|
34d6c15d73 | ||
|
|
d626b7a392 | ||
|
|
87126237ad | ||
|
|
62453ef432 | ||
|
|
c0f85a6bcc | ||
|
|
fa6dac2108 | ||
|
|
0bf5fdb0e5 | ||
|
|
e26b11cce6 | ||
|
|
eb458efa59 |
@@ -16,18 +16,13 @@ stages:
|
|||||||
script:
|
script:
|
||||||
- cd src/$DIR
|
- cd src/$DIR
|
||||||
- make check | tee build.log
|
- make check | tee build.log
|
||||||
- grep -q "FAIL tests/$DIR" build.log && exit 1 || exit 0
|
- grep -vE "^FAIL $IGNORE\$" build.log | grep -q "FAIL tests/$DIR" && exit 1 || exit 0
|
||||||
|
|
||||||
test_devices:
|
test_devices:
|
||||||
extends: .pintos_tests
|
extends: .pintos_tests
|
||||||
variables:
|
variables:
|
||||||
DIR: devices
|
DIR: devices
|
||||||
|
|
||||||
test_filesys:
|
|
||||||
extends: .pintos_tests
|
|
||||||
variables:
|
|
||||||
DIR: filesys
|
|
||||||
|
|
||||||
test_threads:
|
test_threads:
|
||||||
extends: .pintos_tests
|
extends: .pintos_tests
|
||||||
variables:
|
variables:
|
||||||
@@ -42,3 +37,4 @@ test_vm:
|
|||||||
extends: .pintos_tests
|
extends: .pintos_tests
|
||||||
variables:
|
variables:
|
||||||
DIR: vm
|
DIR: vm
|
||||||
|
IGNORE: (tests/vm/pt-grow-stack|tests/vm/pt-grow-pusha|tests/vm/pt-big-stk-obj|tests/vm/pt-overflowstk|tests/vm/pt-write-code2|tests/vm/pt-grow-stk-sc|tests/vm/page-linear|tests/vm/page-parallel|tests/vm/page-merge-seq|tests/vm/page-merge-par|tests/vm/page-merge-stk|tests/vm/page-merge-mm|tests/vm/mmap-read|tests/vm/mmap-close|tests/vm/mmap-overlap|tests/vm/mmap-twice|tests/vm/mmap-write|tests/vm/mmap-exit|tests/vm/mmap-shuffle|tests/vm/mmap-clean|tests/vm/mmap-inherit|tests/vm/mmap-misalign|tests/vm/mmap-null|tests/vm/mmap-over-code|tests/vm/mmap-over-data|tests/vm/mmap-over-stk|tests/vm/mmap-remove)
|
||||||
|
|||||||
@@ -62,7 +62,10 @@ userprog_SRC += userprog/gdt.c # GDT initialization.
|
|||||||
userprog_SRC += userprog/tss.c # TSS management.
|
userprog_SRC += userprog/tss.c # TSS management.
|
||||||
|
|
||||||
# Virtual memory code.
|
# Virtual memory code.
|
||||||
|
vm_SRC += vm/frame.c # Frame table manager.
|
||||||
|
vm_SRC += vm/page.c # Page table manager.
|
||||||
vm_SRC += devices/swap.c # Swap block manager.
|
vm_SRC += devices/swap.c # Swap block manager.
|
||||||
|
vm_SRC += vm/stackgrowth.c
|
||||||
#vm_SRC = vm/file.c # Some other file.
|
#vm_SRC = vm/file.c # Some other file.
|
||||||
|
|
||||||
# Filesystem code.
|
# Filesystem code.
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ SRCDIR = ..
|
|||||||
# To add a new test, put its name on the PROGS list
|
# To add a new test, put its name on the PROGS list
|
||||||
# and then add a name_SRC line that lists its source files.
|
# and then add a name_SRC line that lists its source files.
|
||||||
PROGS = cat cmp cp echo halt hex-dump mcat mcp rm \
|
PROGS = cat cmp cp echo halt hex-dump mcat mcp rm \
|
||||||
bubsort insult lineup matmult recursor
|
bubsort insult lineup matmult recursor args-ovf
|
||||||
|
|
||||||
# Should work from task 2 onward.
|
# Should work from task 2 onward.
|
||||||
cat_SRC = cat.c
|
cat_SRC = cat.c
|
||||||
@@ -18,6 +18,7 @@ lineup_SRC = lineup.c
|
|||||||
ls_SRC = ls.c
|
ls_SRC = ls.c
|
||||||
recursor_SRC = recursor.c
|
recursor_SRC = recursor.c
|
||||||
rm_SRC = rm.c
|
rm_SRC = rm.c
|
||||||
|
args-ovf_SRC = args-ovf.c
|
||||||
|
|
||||||
# Should work in task 3; also in task 4 if VM is included.
|
# Should work in task 3; also in task 4 if VM is included.
|
||||||
bubsort_SRC = bubsort.c
|
bubsort_SRC = bubsort.c
|
||||||
|
|||||||
13
src/examples/args-ovf.c
Normal file
13
src/examples/args-ovf.c
Normal file
File diff suppressed because one or more lines are too long
@@ -4,6 +4,9 @@
|
|||||||
#include "filesys/off_t.h"
|
#include "filesys/off_t.h"
|
||||||
#include <stdbool.h>
|
#include <stdbool.h>
|
||||||
|
|
||||||
|
/* The maximum length of a file name in PintOS. */
|
||||||
|
#define FNAME_MAX_LEN 14
|
||||||
|
|
||||||
struct inode;
|
struct inode;
|
||||||
|
|
||||||
/* Opening and closing files. */
|
/* Opening and closing files. */
|
||||||
|
|||||||
@@ -170,6 +170,9 @@ list_insert (struct list_elem *before, struct list_elem *elem)
|
|||||||
{
|
{
|
||||||
ASSERT (is_interior (before) || is_tail (before));
|
ASSERT (is_interior (before) || is_tail (before));
|
||||||
ASSERT (elem != NULL);
|
ASSERT (elem != NULL);
|
||||||
|
// Sanity checks to prevent (some) loop lists
|
||||||
|
ASSERT (before != elem);
|
||||||
|
ASSERT (before->prev != elem);
|
||||||
|
|
||||||
elem->prev = before->prev;
|
elem->prev = before->prev;
|
||||||
elem->next = before;
|
elem->next = before;
|
||||||
|
|||||||
@@ -166,7 +166,7 @@ mkdir (const char *dir)
|
|||||||
}
|
}
|
||||||
|
|
||||||
bool
|
bool
|
||||||
readdir (int fd, char name[READDIR_MAX_LEN + 1])
|
readdir (int fd, char name[FNAME_MAX_LEN + 1])
|
||||||
{
|
{
|
||||||
return syscall2 (SYS_READDIR, fd, name);
|
return syscall2 (SYS_READDIR, fd, name);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,6 +3,7 @@
|
|||||||
|
|
||||||
#include <stdbool.h>
|
#include <stdbool.h>
|
||||||
#include <debug.h>
|
#include <debug.h>
|
||||||
|
#include "../../filesys/file.h"
|
||||||
|
|
||||||
/* Process identifier. */
|
/* Process identifier. */
|
||||||
typedef int pid_t;
|
typedef int pid_t;
|
||||||
@@ -12,9 +13,6 @@ typedef int pid_t;
|
|||||||
typedef int mapid_t;
|
typedef int mapid_t;
|
||||||
#define MAP_FAILED ((mapid_t) -1)
|
#define MAP_FAILED ((mapid_t) -1)
|
||||||
|
|
||||||
/* Maximum characters in a filename written by readdir(). */
|
|
||||||
#define READDIR_MAX_LEN 14
|
|
||||||
|
|
||||||
/* Typical return values from main() and arguments to exit(). */
|
/* Typical return values from main() and arguments to exit(). */
|
||||||
#define EXIT_SUCCESS 0 /* Successful execution. */
|
#define EXIT_SUCCESS 0 /* Successful execution. */
|
||||||
#define EXIT_FAILURE 1 /* Unsuccessful execution. */
|
#define EXIT_FAILURE 1 /* Unsuccessful execution. */
|
||||||
@@ -41,7 +39,7 @@ void munmap (mapid_t);
|
|||||||
/* Task 4 only. */
|
/* Task 4 only. */
|
||||||
bool chdir (const char *dir);
|
bool chdir (const char *dir);
|
||||||
bool mkdir (const char *dir);
|
bool mkdir (const char *dir);
|
||||||
bool readdir (int fd, char name[READDIR_MAX_LEN + 1]);
|
bool readdir (int fd, char name[FNAME_MAX_LEN + 1]);
|
||||||
bool isdir (int fd);
|
bool isdir (int fd);
|
||||||
int inumber (int fd);
|
int inumber (int fd);
|
||||||
|
|
||||||
|
|||||||
@@ -9,14 +9,14 @@ sc-bad-arg sc-bad-num sc-boundary sc-boundary-2 halt exit create-normal \
|
|||||||
create-empty create-null create-bad-ptr create-long create-exists \
|
create-empty create-null create-bad-ptr create-long create-exists \
|
||||||
create-bound open-normal open-missing open-boundary open-empty \
|
create-bound open-normal open-missing open-boundary open-empty \
|
||||||
open-null open-bad-ptr open-twice close-normal close-twice close-stdin \
|
open-null open-bad-ptr open-twice close-normal close-twice close-stdin \
|
||||||
close-stdout close-bad-fd read-normal read-bad-ptr read-boundary \
|
close-stdout close-bad-fd read-normal read-bad-ptr read-bad-buf read-boundary \
|
||||||
read-zero read-stdout read-bad-fd write-normal write-bad-ptr \
|
read-zero read-stdout read-bad-fd write-normal write-bad-ptr write-bad-buf \
|
||||||
write-boundary write-zero write-stdin write-bad-fd exec-once exec-arg \
|
write-boundary write-zero write-stdin write-bad-fd exec-once exec-arg \
|
||||||
exec-large-arg exec-multiple exec-missing exec-over-arg exec-over-args \
|
exec-large-arg exec-multiple exec-missing exec-over-arg exec-over-args \
|
||||||
exec-bad-ptr wait-simple wait-twice wait-killed wait-load-kill \
|
exec-bad-ptr wait-simple wait-twice wait-killed wait-load-kill \
|
||||||
wait-bad-pid wait-bad-child multi-recurse multi-child-fd rox-simple \
|
wait-bad-pid wait-bad-child multi-recurse multi-child-fd rox-simple \
|
||||||
rox-child rox-multichild bad-read bad-write bad-read2 bad-write2 \
|
rox-child rox-multichild bad-read bad-write bad-read2 bad-write2 \
|
||||||
bad-jump bad-jump2 bad-maths)
|
bad-jump bad-jump2 bad-maths overflow-stack)
|
||||||
|
|
||||||
tests/userprog_PROGS = $(tests/userprog_TESTS) $(addprefix \
|
tests/userprog_PROGS = $(tests/userprog_TESTS) $(addprefix \
|
||||||
tests/userprog/,child-simple child-args child-bad child-close child-rox exec-exit)
|
tests/userprog/,child-simple child-args child-bad child-close child-rox exec-exit)
|
||||||
@@ -36,6 +36,7 @@ tests/userprog/bad-read2_SRC = tests/userprog/bad-read2.c tests/main.c
|
|||||||
tests/userprog/bad-write2_SRC = tests/userprog/bad-write2.c tests/main.c
|
tests/userprog/bad-write2_SRC = tests/userprog/bad-write2.c tests/main.c
|
||||||
tests/userprog/bad-jump2_SRC = tests/userprog/bad-jump2.c tests/main.c
|
tests/userprog/bad-jump2_SRC = tests/userprog/bad-jump2.c tests/main.c
|
||||||
tests/userprog/bad-maths_SRC = tests/userprog/bad-maths.c tests/main.c
|
tests/userprog/bad-maths_SRC = tests/userprog/bad-maths.c tests/main.c
|
||||||
|
tests/userprog/overflow-stack_SRC = tests/userprog/overflow-stack.c tests/main.c
|
||||||
tests/userprog/sc-boundary_SRC = tests/userprog/sc-boundary.c \
|
tests/userprog/sc-boundary_SRC = tests/userprog/sc-boundary.c \
|
||||||
tests/userprog/boundary.c tests/main.c
|
tests/userprog/boundary.c tests/main.c
|
||||||
tests/userprog/sc-boundary-2_SRC = tests/userprog/sc-boundary-2.c \
|
tests/userprog/sc-boundary-2_SRC = tests/userprog/sc-boundary-2.c \
|
||||||
@@ -66,6 +67,7 @@ tests/userprog/close-stdout_SRC = tests/userprog/close-stdout.c tests/main.c
|
|||||||
tests/userprog/close-bad-fd_SRC = tests/userprog/close-bad-fd.c tests/main.c
|
tests/userprog/close-bad-fd_SRC = tests/userprog/close-bad-fd.c tests/main.c
|
||||||
tests/userprog/read-normal_SRC = tests/userprog/read-normal.c tests/main.c
|
tests/userprog/read-normal_SRC = tests/userprog/read-normal.c tests/main.c
|
||||||
tests/userprog/read-bad-ptr_SRC = tests/userprog/read-bad-ptr.c tests/main.c
|
tests/userprog/read-bad-ptr_SRC = tests/userprog/read-bad-ptr.c tests/main.c
|
||||||
|
tests/userprog/read-bad-buf_SRC = tests/userprog/read-bad-buf.c tests/main.c
|
||||||
tests/userprog/read-boundary_SRC = tests/userprog/read-boundary.c \
|
tests/userprog/read-boundary_SRC = tests/userprog/read-boundary.c \
|
||||||
tests/userprog/boundary.c tests/main.c
|
tests/userprog/boundary.c tests/main.c
|
||||||
tests/userprog/read-zero_SRC = tests/userprog/read-zero.c tests/main.c
|
tests/userprog/read-zero_SRC = tests/userprog/read-zero.c tests/main.c
|
||||||
@@ -73,6 +75,7 @@ tests/userprog/read-stdout_SRC = tests/userprog/read-stdout.c tests/main.c
|
|||||||
tests/userprog/read-bad-fd_SRC = tests/userprog/read-bad-fd.c tests/main.c
|
tests/userprog/read-bad-fd_SRC = tests/userprog/read-bad-fd.c tests/main.c
|
||||||
tests/userprog/write-normal_SRC = tests/userprog/write-normal.c tests/main.c
|
tests/userprog/write-normal_SRC = tests/userprog/write-normal.c tests/main.c
|
||||||
tests/userprog/write-bad-ptr_SRC = tests/userprog/write-bad-ptr.c tests/main.c
|
tests/userprog/write-bad-ptr_SRC = tests/userprog/write-bad-ptr.c tests/main.c
|
||||||
|
tests/userprog/write-bad-buf_SRC = tests/userprog/write-bad-buf.c tests/main.c
|
||||||
tests/userprog/write-boundary_SRC = tests/userprog/write-boundary.c \
|
tests/userprog/write-boundary_SRC = tests/userprog/write-boundary.c \
|
||||||
tests/userprog/boundary.c tests/main.c
|
tests/userprog/boundary.c tests/main.c
|
||||||
tests/userprog/write-zero_SRC = tests/userprog/write-zero.c tests/main.c
|
tests/userprog/write-zero_SRC = tests/userprog/write-zero.c tests/main.c
|
||||||
@@ -122,10 +125,12 @@ tests/userprog/close-normal_PUTFILES += tests/userprog/sample.txt
|
|||||||
tests/userprog/close-twice_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/close-twice_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/read-normal_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/read-normal_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/read-bad-ptr_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/read-bad-ptr_PUTFILES += tests/userprog/sample.txt
|
||||||
|
tests/userprog/read-bad-buf_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/read-boundary_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/read-boundary_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/read-zero_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/read-zero_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/write-normal_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/write-normal_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/write-bad-ptr_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/write-bad-ptr_PUTFILES += tests/userprog/sample.txt
|
||||||
|
tests/userprog/write-bad-buf_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/write-boundary_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/write-boundary_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/write-zero_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/write-zero_PUTFILES += tests/userprog/sample.txt
|
||||||
tests/userprog/multi-child-fd_PUTFILES += tests/userprog/sample.txt
|
tests/userprog/multi-child-fd_PUTFILES += tests/userprog/sample.txt
|
||||||
|
|||||||
@@ -1,5 +1,9 @@
|
|||||||
Full robustness of argument passing code:
|
Full robustness of argument passing and syscall handling code:
|
||||||
- Test user stack overflow robustness of "exec" system calls.
|
- Test user stack overflow robustness of "exec" system calls and user code.
|
||||||
5 exec-over-arg
|
5 exec-over-arg
|
||||||
5 exec-over-args
|
5 exec-over-args
|
||||||
|
5 overflow-stack
|
||||||
|
|
||||||
|
- Test syscall user provided buffer validity checks.
|
||||||
|
5 read-bad-buf
|
||||||
|
5 write-bad-buf
|
||||||
|
|||||||
@@ -2,11 +2,7 @@
|
|||||||
use strict;
|
use strict;
|
||||||
use warnings;
|
use warnings;
|
||||||
use tests::tests;
|
use tests::tests;
|
||||||
check_expected ([<<'EOF', <<'EOF']);
|
check_expected ([<<'EOF']);
|
||||||
(exec-bad-ptr) begin
|
|
||||||
(exec-bad-ptr) end
|
|
||||||
exec-bad-ptr: exit(0)
|
|
||||||
EOF
|
|
||||||
(exec-bad-ptr) begin
|
(exec-bad-ptr) begin
|
||||||
exec-bad-ptr: exit(-1)
|
exec-bad-ptr: exit(-1)
|
||||||
EOF
|
EOF
|
||||||
|
|||||||
@@ -2,11 +2,7 @@
|
|||||||
use strict;
|
use strict;
|
||||||
use warnings;
|
use warnings;
|
||||||
use tests::tests;
|
use tests::tests;
|
||||||
check_expected ([<<'EOF', <<'EOF']);
|
check_expected ([<<'EOF']);
|
||||||
(open-bad-ptr) begin
|
|
||||||
(open-bad-ptr) end
|
|
||||||
open-bad-ptr: exit(0)
|
|
||||||
EOF
|
|
||||||
(open-bad-ptr) begin
|
(open-bad-ptr) begin
|
||||||
open-bad-ptr: exit(-1)
|
open-bad-ptr: exit(-1)
|
||||||
EOF
|
EOF
|
||||||
|
|||||||
17
src/tests/userprog/overflow-stack.c
Normal file
17
src/tests/userprog/overflow-stack.c
Normal file
@@ -0,0 +1,17 @@
|
|||||||
|
/* Attempt to overflow the user stack by allocating a 4kB buffer and writing into it.
|
||||||
|
The process must be terminated with -1 exit code until stack growth has been implemented in Task 3
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <string.h>
|
||||||
|
#include <syscall.h>
|
||||||
|
#include "tests/lib.h"
|
||||||
|
#include "tests/main.h"
|
||||||
|
|
||||||
|
void
|
||||||
|
test_main (void)
|
||||||
|
{
|
||||||
|
char stack_obj[4096];
|
||||||
|
memset (stack_obj, 'a', sizeof stack_obj);
|
||||||
|
memset (stack_obj+10, '\0', 1);
|
||||||
|
msg ("buffer: %s", stack_obj);
|
||||||
|
}
|
||||||
14
src/tests/userprog/overflow-stack.ck
Normal file
14
src/tests/userprog/overflow-stack.ck
Normal file
@@ -0,0 +1,14 @@
|
|||||||
|
# -*- perl -*-
|
||||||
|
use strict;
|
||||||
|
use warnings;
|
||||||
|
use tests::tests;
|
||||||
|
check_expected (IGNORE_USER_FAULTS => 1, [<<'EOF',<<'EOF']);
|
||||||
|
(overflow-stack) begin
|
||||||
|
overflow-stack: exit(-1)
|
||||||
|
EOF
|
||||||
|
(overflow-stack) begin
|
||||||
|
(overflow-stack) buffer: aaaaaaaaaa
|
||||||
|
(overflow-stack) end
|
||||||
|
overflow-stack: exit(0)
|
||||||
|
EOF
|
||||||
|
pass;
|
||||||
17
src/tests/userprog/read-bad-buf.c
Normal file
17
src/tests/userprog/read-bad-buf.c
Normal file
@@ -0,0 +1,17 @@
|
|||||||
|
/* Passes a buffer to the read system call that starts in valid memory, but runs into kernel space.
|
||||||
|
The process must be terminated with -1 exit code.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <syscall.h>
|
||||||
|
#include "tests/lib.h"
|
||||||
|
#include "tests/main.h"
|
||||||
|
|
||||||
|
void
|
||||||
|
test_main (void)
|
||||||
|
{
|
||||||
|
int handle;
|
||||||
|
CHECK ((handle = open ("sample.txt")) > 1, "open \"sample.txt\"");
|
||||||
|
|
||||||
|
read (handle, (char *) 0xbfffffe0, 100);
|
||||||
|
fail ("should not have survived read()");
|
||||||
|
}
|
||||||
10
src/tests/userprog/read-bad-buf.ck
Normal file
10
src/tests/userprog/read-bad-buf.ck
Normal file
@@ -0,0 +1,10 @@
|
|||||||
|
# -*- perl -*-
|
||||||
|
use strict;
|
||||||
|
use warnings;
|
||||||
|
use tests::tests;
|
||||||
|
check_expected (IGNORE_KERNEL_FAULTS => 1, [<<'EOF']);
|
||||||
|
(read-bad-buf) begin
|
||||||
|
(read-bad-buf) open "sample.txt"
|
||||||
|
read-bad-buf: exit(-1)
|
||||||
|
EOF
|
||||||
|
pass;
|
||||||
@@ -2,12 +2,7 @@
|
|||||||
use strict;
|
use strict;
|
||||||
use warnings;
|
use warnings;
|
||||||
use tests::tests;
|
use tests::tests;
|
||||||
check_expected ([<<'EOF', <<'EOF']);
|
check_expected ([<<'EOF']);
|
||||||
(read-bad-ptr) begin
|
|
||||||
(read-bad-ptr) open "sample.txt"
|
|
||||||
(read-bad-ptr) end
|
|
||||||
read-bad-ptr: exit(0)
|
|
||||||
EOF
|
|
||||||
(read-bad-ptr) begin
|
(read-bad-ptr) begin
|
||||||
(read-bad-ptr) open "sample.txt"
|
(read-bad-ptr) open "sample.txt"
|
||||||
read-bad-ptr: exit(-1)
|
read-bad-ptr: exit(-1)
|
||||||
|
|||||||
17
src/tests/userprog/write-bad-buf.c
Normal file
17
src/tests/userprog/write-bad-buf.c
Normal file
@@ -0,0 +1,17 @@
|
|||||||
|
/* Passes a buffer to the write system call that starts in valid memory, but runs into kernel space.
|
||||||
|
The process must be terminated with -1 exit code.
|
||||||
|
*/
|
||||||
|
|
||||||
|
#include <syscall.h>
|
||||||
|
#include "tests/lib.h"
|
||||||
|
#include "tests/main.h"
|
||||||
|
|
||||||
|
void
|
||||||
|
test_main (void)
|
||||||
|
{
|
||||||
|
int handle;
|
||||||
|
CHECK ((handle = open ("sample.txt")) > 1, "open \"sample.txt\"");
|
||||||
|
|
||||||
|
write (handle, (char *) 0xbffffff0, 32);
|
||||||
|
fail ("should have exited with -1");
|
||||||
|
}
|
||||||
10
src/tests/userprog/write-bad-buf.ck
Normal file
10
src/tests/userprog/write-bad-buf.ck
Normal file
@@ -0,0 +1,10 @@
|
|||||||
|
# -*- perl -*-
|
||||||
|
use strict;
|
||||||
|
use warnings;
|
||||||
|
use tests::tests;
|
||||||
|
check_expected (IGNORE_KERNEL_FAULTS => 1, [<<'EOF']);
|
||||||
|
(write-bad-buf) begin
|
||||||
|
(write-bad-buf) open "sample.txt"
|
||||||
|
write-bad-buf: exit(-1)
|
||||||
|
EOF
|
||||||
|
pass;
|
||||||
@@ -2,12 +2,7 @@
|
|||||||
use strict;
|
use strict;
|
||||||
use warnings;
|
use warnings;
|
||||||
use tests::tests;
|
use tests::tests;
|
||||||
check_expected ([<<'EOF', <<'EOF']);
|
check_expected ([<<'EOF']);
|
||||||
(write-bad-ptr) begin
|
|
||||||
(write-bad-ptr) open "sample.txt"
|
|
||||||
(write-bad-ptr) end
|
|
||||||
write-bad-ptr: exit(0)
|
|
||||||
EOF
|
|
||||||
(write-bad-ptr) begin
|
(write-bad-ptr) begin
|
||||||
(write-bad-ptr) open "sample.txt"
|
(write-bad-ptr) open "sample.txt"
|
||||||
write-bad-ptr: exit(-1)
|
write-bad-ptr: exit(-1)
|
||||||
|
|||||||
@@ -32,6 +32,7 @@
|
|||||||
#include "tests/threads/tests.h"
|
#include "tests/threads/tests.h"
|
||||||
#endif
|
#endif
|
||||||
#ifdef VM
|
#ifdef VM
|
||||||
|
#include "vm/frame.h"
|
||||||
#include "devices/swap.h"
|
#include "devices/swap.h"
|
||||||
#endif
|
#endif
|
||||||
#ifdef FILESYS
|
#ifdef FILESYS
|
||||||
@@ -101,6 +102,9 @@ main (void)
|
|||||||
palloc_init (user_page_limit);
|
palloc_init (user_page_limit);
|
||||||
malloc_init ();
|
malloc_init ();
|
||||||
paging_init ();
|
paging_init ();
|
||||||
|
#ifdef VM
|
||||||
|
frame_init ();
|
||||||
|
#endif
|
||||||
|
|
||||||
/* Segmentation. */
|
/* Segmentation. */
|
||||||
#ifdef USERPROG
|
#ifdef USERPROG
|
||||||
|
|||||||
@@ -113,6 +113,7 @@ void
|
|||||||
sema_up (struct semaphore *sema)
|
sema_up (struct semaphore *sema)
|
||||||
{
|
{
|
||||||
enum intr_level old_level;
|
enum intr_level old_level;
|
||||||
|
bool thread_unblocked = false; /* Flag to track if any thread was woken up. */
|
||||||
|
|
||||||
ASSERT (sema != NULL);
|
ASSERT (sema != NULL);
|
||||||
|
|
||||||
@@ -124,6 +125,7 @@ sema_up (struct semaphore *sema)
|
|||||||
struct list_elem *e = list_max (&sema->waiters, priority_less, NULL);
|
struct list_elem *e = list_max (&sema->waiters, priority_less, NULL);
|
||||||
list_remove (e);
|
list_remove (e);
|
||||||
thread_unblock (list_entry (e, struct thread, elem));
|
thread_unblock (list_entry (e, struct thread, elem));
|
||||||
|
thread_unblocked = true;
|
||||||
}
|
}
|
||||||
sema->value++;
|
sema->value++;
|
||||||
intr_set_level (old_level);
|
intr_set_level (old_level);
|
||||||
@@ -131,10 +133,13 @@ sema_up (struct semaphore *sema)
|
|||||||
/* Yields the CPU in case the thread that has been woken up has a higher
|
/* Yields the CPU in case the thread that has been woken up has a higher
|
||||||
priority that the current running thread, including the case when called
|
priority that the current running thread, including the case when called
|
||||||
within an interrupt handler. */
|
within an interrupt handler. */
|
||||||
if (intr_context ())
|
if (thread_unblocked)
|
||||||
intr_yield_on_return ();
|
{
|
||||||
else
|
if (intr_context ())
|
||||||
thread_yield ();
|
intr_yield_on_return ();
|
||||||
|
else
|
||||||
|
thread_yield ();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
static void sema_test_helper (void *sema_);
|
static void sema_test_helper (void *sema_);
|
||||||
@@ -207,6 +212,7 @@ donate_priority (struct thread *donee) {
|
|||||||
ASSERT (intr_get_level () == INTR_OFF);
|
ASSERT (intr_get_level () == INTR_OFF);
|
||||||
|
|
||||||
struct thread *donor = thread_current ();
|
struct thread *donor = thread_current ();
|
||||||
|
list_remove (&donor->donor_elem);
|
||||||
list_push_back (&donee->donors_list, &donor->donor_elem);
|
list_push_back (&donee->donors_list, &donor->donor_elem);
|
||||||
|
|
||||||
while (donee != NULL)
|
while (donee != NULL)
|
||||||
@@ -255,6 +261,7 @@ lock_acquire (struct lock *lock)
|
|||||||
ASSERT (!lock_held_by_current_thread (lock));
|
ASSERT (!lock_held_by_current_thread (lock));
|
||||||
|
|
||||||
struct thread *t = thread_current ();
|
struct thread *t = thread_current ();
|
||||||
|
ASSERT (t->waiting_lock == NULL);
|
||||||
|
|
||||||
enum intr_level old_level = intr_disable ();
|
enum intr_level old_level = intr_disable ();
|
||||||
if (lock->holder != NULL)
|
if (lock->holder != NULL)
|
||||||
@@ -347,7 +354,6 @@ lock_release (struct lock *lock)
|
|||||||
|
|
||||||
lock->holder = NULL;
|
lock->holder = NULL;
|
||||||
sema_up (&lock->semaphore);
|
sema_up (&lock->semaphore);
|
||||||
thread_yield ();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Returns true if the current thread holds LOCK, false
|
/* Returns true if the current thread holds LOCK, false
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
#include "threads/thread.h"
|
#include "threads/thread.h"
|
||||||
#include <debug.h>
|
#include <debug.h>
|
||||||
|
#include <hash.h>
|
||||||
#include <stddef.h>
|
#include <stddef.h>
|
||||||
#include <random.h>
|
#include <random.h>
|
||||||
#include <stdio.h>
|
#include <stdio.h>
|
||||||
@@ -9,12 +10,14 @@
|
|||||||
#include "threads/flags.h"
|
#include "threads/flags.h"
|
||||||
#include "threads/interrupt.h"
|
#include "threads/interrupt.h"
|
||||||
#include "threads/intr-stubs.h"
|
#include "threads/intr-stubs.h"
|
||||||
|
#include "threads/malloc.h"
|
||||||
#include "threads/palloc.h"
|
#include "threads/palloc.h"
|
||||||
#include "threads/switch.h"
|
#include "threads/switch.h"
|
||||||
#include "threads/synch.h"
|
#include "threads/synch.h"
|
||||||
#include "threads/vaddr.h"
|
#include "threads/vaddr.h"
|
||||||
#ifdef USERPROG
|
#ifdef USERPROG
|
||||||
#include "userprog/process.h"
|
#include "userprog/process.h"
|
||||||
|
#include "userprog/syscall.h"
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
/* Random value for struct thread's `magic' member.
|
/* Random value for struct thread's `magic' member.
|
||||||
@@ -68,6 +71,7 @@ static void kernel_thread (thread_func *, void *aux);
|
|||||||
static void idle (void *aux UNUSED);
|
static void idle (void *aux UNUSED);
|
||||||
static struct thread *running_thread (void);
|
static struct thread *running_thread (void);
|
||||||
static struct thread *next_thread_to_run (void);
|
static struct thread *next_thread_to_run (void);
|
||||||
|
static bool init_process_result (struct thread *t);
|
||||||
static void init_thread (struct thread *, const char *name, int nice,
|
static void init_thread (struct thread *, const char *name, int nice,
|
||||||
int priority, fp32_t recent_cpu);
|
int priority, fp32_t recent_cpu);
|
||||||
static bool is_thread (struct thread *) UNUSED;
|
static bool is_thread (struct thread *) UNUSED;
|
||||||
@@ -80,6 +84,10 @@ void thread_schedule_tail (struct thread *prev);
|
|||||||
static tid_t allocate_tid (void);
|
static tid_t allocate_tid (void);
|
||||||
static bool donor_priority_less (const struct list_elem *a_,
|
static bool donor_priority_less (const struct list_elem *a_,
|
||||||
const struct list_elem *b_, void *aux UNUSED);
|
const struct list_elem *b_, void *aux UNUSED);
|
||||||
|
static unsigned process_result_hash (const struct hash_elem *e,
|
||||||
|
void *aux UNUSED);
|
||||||
|
static bool process_result_less (const struct hash_elem *a,
|
||||||
|
const struct hash_elem *b, void *aux UNUSED);
|
||||||
|
|
||||||
/* Initializes the threading system by transforming the code
|
/* Initializes the threading system by transforming the code
|
||||||
that's currently running into a thread. This can't work in
|
that's currently running into a thread. This can't work in
|
||||||
@@ -110,6 +118,7 @@ thread_init (void)
|
|||||||
initial_thread_recent_cpu);
|
initial_thread_recent_cpu);
|
||||||
initial_thread->status = THREAD_RUNNING;
|
initial_thread->status = THREAD_RUNNING;
|
||||||
initial_thread->tid = allocate_tid ();
|
initial_thread->tid = allocate_tid ();
|
||||||
|
initial_thread->result = NULL; /* Main thread cannot be waited for. */
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Starts preemptive thread scheduling by enabling interrupts.
|
/* Starts preemptive thread scheduling by enabling interrupts.
|
||||||
@@ -117,6 +126,13 @@ thread_init (void)
|
|||||||
void
|
void
|
||||||
thread_start (void)
|
thread_start (void)
|
||||||
{
|
{
|
||||||
|
/* Malloc has been initalised, we can allocate the child results table
|
||||||
|
for the main thread. */
|
||||||
|
struct thread *t = thread_current ();
|
||||||
|
if (!hash_init (&t->child_results, process_result_hash, process_result_less,
|
||||||
|
t))
|
||||||
|
PANIC ("Failed to initialise child results table for main thread.");
|
||||||
|
|
||||||
/* Create the idle thread. */
|
/* Create the idle thread. */
|
||||||
struct semaphore idle_started;
|
struct semaphore idle_started;
|
||||||
sema_init (&idle_started, 0);
|
sema_init (&idle_started, 0);
|
||||||
@@ -236,6 +252,25 @@ thread_create (const char *name, int priority,
|
|||||||
struct thread *parent_thread = thread_current ();
|
struct thread *parent_thread = thread_current ();
|
||||||
init_thread (t, name, parent_thread->nice, priority, parent_thread->recent_cpu);
|
init_thread (t, name, parent_thread->nice, priority, parent_thread->recent_cpu);
|
||||||
tid = t->tid = allocate_tid ();
|
tid = t->tid = allocate_tid ();
|
||||||
|
if (!init_process_result (t))
|
||||||
|
{
|
||||||
|
palloc_free_page (t);
|
||||||
|
return TID_ERROR;
|
||||||
|
}
|
||||||
|
|
||||||
|
#ifdef USERPROG
|
||||||
|
/* Initialize the thread's file descriptor table. */
|
||||||
|
t->fd_counter = MINIMUM_USER_FD;
|
||||||
|
|
||||||
|
if (!hash_init (&t->open_files, fd_hash, fd_less, NULL)
|
||||||
|
|| !hash_init (&t->child_results, process_result_hash,
|
||||||
|
process_result_less, t))
|
||||||
|
{
|
||||||
|
palloc_free_page (t);
|
||||||
|
free (t->result);
|
||||||
|
return TID_ERROR;
|
||||||
|
}
|
||||||
|
#endif
|
||||||
|
|
||||||
/* Prepare thread for first run by initializing its stack.
|
/* Prepare thread for first run by initializing its stack.
|
||||||
Do this atomically so intermediate values for the 'stack'
|
Do this atomically so intermediate values for the 'stack'
|
||||||
@@ -259,6 +294,8 @@ thread_create (const char *name, int priority,
|
|||||||
|
|
||||||
intr_set_level (old_level);
|
intr_set_level (old_level);
|
||||||
|
|
||||||
|
hash_insert (&parent_thread->child_results, &t->result->elem);
|
||||||
|
|
||||||
/* Add to run queue. */
|
/* Add to run queue. */
|
||||||
thread_unblock (t);
|
thread_unblock (t);
|
||||||
|
|
||||||
@@ -359,7 +396,9 @@ thread_exit (void)
|
|||||||
and schedule another process. That process will destroy us
|
and schedule another process. That process will destroy us
|
||||||
when it calls thread_schedule_tail(). */
|
when it calls thread_schedule_tail(). */
|
||||||
intr_disable ();
|
intr_disable ();
|
||||||
list_remove (&thread_current()->allelem);
|
struct thread *t = thread_current ();
|
||||||
|
list_remove (&t->allelem);
|
||||||
|
list_remove (&t->donor_elem);
|
||||||
thread_current ()->status = THREAD_DYING;
|
thread_current ()->status = THREAD_DYING;
|
||||||
schedule ();
|
schedule ();
|
||||||
NOT_REACHED ();
|
NOT_REACHED ();
|
||||||
@@ -632,6 +671,21 @@ is_thread (struct thread *t)
|
|||||||
return t != NULL && t->magic == THREAD_MAGIC;
|
return t != NULL && t->magic == THREAD_MAGIC;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Allocate and initialise a process result for given thread. */
|
||||||
|
static bool
|
||||||
|
init_process_result (struct thread *t)
|
||||||
|
{
|
||||||
|
struct process_result *result = malloc (sizeof (struct process_result));
|
||||||
|
if (result == NULL)
|
||||||
|
return false;
|
||||||
|
result->tid = t->tid;
|
||||||
|
result->exit_status = -1;
|
||||||
|
lock_init (&result->lock);
|
||||||
|
sema_init (&result->sema, 0);
|
||||||
|
t->result = result;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
/* Does basic initialization of T as a blocked thread named
|
/* Does basic initialization of T as a blocked thread named
|
||||||
NAME. */
|
NAME. */
|
||||||
static void
|
static void
|
||||||
@@ -653,6 +707,7 @@ init_thread (struct thread *t, const char *name, int nice, int priority,
|
|||||||
t->base_priority
|
t->base_priority
|
||||||
= thread_mlfqs ? calculate_bsd_priority (recent_cpu, nice) : priority;
|
= thread_mlfqs ? calculate_bsd_priority (recent_cpu, nice) : priority;
|
||||||
list_init (&t->donors_list);
|
list_init (&t->donors_list);
|
||||||
|
list_push_back (&t->donors_list, &t->donor_elem);
|
||||||
t->waiting_lock = NULL;
|
t->waiting_lock = NULL;
|
||||||
|
|
||||||
t->nice = nice;
|
t->nice = nice;
|
||||||
@@ -789,6 +844,29 @@ allocate_tid (void)
|
|||||||
return tid;
|
return tid;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Hashing function needed for child_results table.
|
||||||
|
Returns hash of process_result's TID. */
|
||||||
|
static unsigned
|
||||||
|
process_result_hash (const struct hash_elem *e, void *aux UNUSED)
|
||||||
|
{
|
||||||
|
const struct process_result *result
|
||||||
|
= hash_entry (e, struct process_result, elem);
|
||||||
|
return hash_int (result->tid);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Comparator function needed for child_results table.
|
||||||
|
Returns less than comparison on process_results' TIDs. */
|
||||||
|
static bool
|
||||||
|
process_result_less (const struct hash_elem *a_, const struct hash_elem *b_,
|
||||||
|
void *aux UNUSED)
|
||||||
|
{
|
||||||
|
const struct process_result *a
|
||||||
|
= hash_entry (a_, struct process_result, elem);
|
||||||
|
const struct process_result *b
|
||||||
|
= hash_entry (b_, struct process_result, elem);
|
||||||
|
return a->tid < b->tid;
|
||||||
|
}
|
||||||
|
|
||||||
/* Offset of `stack' member within `struct thread'.
|
/* Offset of `stack' member within `struct thread'.
|
||||||
Used by switch.S, which can't figure it out on its own. */
|
Used by switch.S, which can't figure it out on its own. */
|
||||||
uint32_t thread_stack_ofs = offsetof (struct thread, stack);
|
uint32_t thread_stack_ofs = offsetof (struct thread, stack);
|
||||||
|
|||||||
@@ -2,8 +2,11 @@
|
|||||||
#define THREADS_THREAD_H
|
#define THREADS_THREAD_H
|
||||||
|
|
||||||
#include <debug.h>
|
#include <debug.h>
|
||||||
|
#include <hash.h>
|
||||||
#include <list.h>
|
#include <list.h>
|
||||||
#include <stdint.h>
|
#include <stdint.h>
|
||||||
|
#include <stdbool.h>
|
||||||
|
#include "threads/synch.h"
|
||||||
#include "threads/fixed-point.h"
|
#include "threads/fixed-point.h"
|
||||||
|
|
||||||
/* States in a thread's life cycle. */
|
/* States in a thread's life cycle. */
|
||||||
@@ -29,6 +32,21 @@ typedef int tid_t;
|
|||||||
#define NICE_DEFAULT 0 /* Default niceness. */
|
#define NICE_DEFAULT 0 /* Default niceness. */
|
||||||
#define NICE_MAX 20 /* Highest niceness. */
|
#define NICE_MAX 20 /* Highest niceness. */
|
||||||
|
|
||||||
|
/* File Descriptors. */
|
||||||
|
#define MINIMUM_USER_FD 2 /* Minimum file descriptor for user programs. */
|
||||||
|
|
||||||
|
/* A process result, synchronised between parent and child. */
|
||||||
|
struct process_result
|
||||||
|
{
|
||||||
|
tid_t tid; /* The tid of the child process. */
|
||||||
|
int exit_status; /* The exit status of the child process. Initially set
|
||||||
|
to -1, then to exit_status when child dies. */
|
||||||
|
struct lock lock; /* Lock the exit_status and sema. */
|
||||||
|
struct semaphore sema; /* Semaphore to signal the parent that the exit_status
|
||||||
|
has been set. */
|
||||||
|
struct hash_elem elem; /* Hash element for the parent's children map. */
|
||||||
|
};
|
||||||
|
|
||||||
/* A kernel thread or user process.
|
/* A kernel thread or user process.
|
||||||
|
|
||||||
Each thread structure is stored in its own 4 kB page. The
|
Each thread structure is stored in its own 4 kB page. The
|
||||||
@@ -108,15 +126,25 @@ struct thread
|
|||||||
int nice; /* Nice value for this thread */
|
int nice; /* Nice value for this thread */
|
||||||
fp32_t recent_cpu; /* Amount of time this process received */
|
fp32_t recent_cpu; /* Amount of time this process received */
|
||||||
|
|
||||||
|
/* Process wait properties. */
|
||||||
|
struct process_result *result; /* Result of the process. */
|
||||||
|
struct hash child_results; /* Map of children's of this thread
|
||||||
|
TID to process result. */
|
||||||
|
struct file *exec_file; /* Thread's currently running file */
|
||||||
|
|
||||||
/* Shared between thread.c and synch.c. */
|
/* Shared between thread.c and synch.c. */
|
||||||
struct list_elem elem; /* List element. */
|
struct list_elem elem; /* List element. */
|
||||||
|
|
||||||
|
|
||||||
#ifdef USERPROG
|
#ifdef USERPROG
|
||||||
/* Owned by userprog/process.c. */
|
/* Owned by userprog/process.c. */
|
||||||
uint32_t *pagedir; /* Page directory. */
|
uint32_t *pagedir; /* Page directory. */
|
||||||
|
unsigned int fd_counter; /* File descriptor counter for thread's
|
||||||
|
open files. */
|
||||||
|
struct hash open_files; /* Hash Table of FD -> Struct File. */
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
void *curr_esp;
|
||||||
|
|
||||||
/* Owned by thread.c. */
|
/* Owned by thread.c. */
|
||||||
unsigned magic; /* Detects stack overflow. */
|
unsigned magic; /* Detects stack overflow. */
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
# -*- makefile -*-
|
# -*- makefile -*-
|
||||||
|
|
||||||
kernel.bin: DEFINES = -DUSERPROG -DFILESYS
|
kernel.bin: DEFINES = -DUSERPROG -DFILESYS -DVM
|
||||||
KERNEL_SUBDIRS = threads devices lib lib/kernel userprog filesys
|
KERNEL_SUBDIRS = threads devices lib lib/kernel userprog filesys vm
|
||||||
TEST_SUBDIRS = tests/userprog tests/userprog/no-vm tests/filesys/base
|
TEST_SUBDIRS = tests/userprog tests/userprog/no-vm tests/filesys/base
|
||||||
GRADING_FILE = $(SRCDIR)/tests/userprog/Grading
|
GRADING_FILE = $(SRCDIR)/tests/userprog/Grading
|
||||||
SIMULATOR = --qemu
|
SIMULATOR = --qemu
|
||||||
|
|||||||
@@ -4,6 +4,7 @@
|
|||||||
#include "userprog/gdt.h"
|
#include "userprog/gdt.h"
|
||||||
#include "threads/interrupt.h"
|
#include "threads/interrupt.h"
|
||||||
#include "threads/thread.h"
|
#include "threads/thread.h"
|
||||||
|
#include "vm/stackgrowth.h"
|
||||||
|
|
||||||
/* Number of page faults processed. */
|
/* Number of page faults processed. */
|
||||||
static long long page_fault_cnt;
|
static long long page_fault_cnt;
|
||||||
@@ -145,6 +146,20 @@ page_fault (struct intr_frame *f)
|
|||||||
write = (f->error_code & PF_W) != 0;
|
write = (f->error_code & PF_W) != 0;
|
||||||
user = (f->error_code & PF_U) != 0;
|
user = (f->error_code & PF_U) != 0;
|
||||||
|
|
||||||
|
if (user && not_present)
|
||||||
|
{
|
||||||
|
if (try_alloc_new_page (fault_addr, f->esp))
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
if (try_alloc_new_page (fault_addr, thread_current ()->curr_esp))
|
||||||
|
return;
|
||||||
|
f->eip = (void *)f->eax;
|
||||||
|
f->eax = 0xffffffff;
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
/* To implement virtual memory, delete the rest of the function
|
/* To implement virtual memory, delete the rest of the function
|
||||||
body, and replace it with code that brings in the page to
|
body, and replace it with code that brings in the page to
|
||||||
which fault_addr refers. */
|
which fault_addr refers. */
|
||||||
|
|||||||
@@ -1,12 +1,15 @@
|
|||||||
#include "userprog/process.h"
|
#include "userprog/process.h"
|
||||||
#include <debug.h>
|
#include <debug.h>
|
||||||
|
#include <hash.h>
|
||||||
#include <inttypes.h>
|
#include <inttypes.h>
|
||||||
|
#include <list.h>
|
||||||
#include <round.h>
|
#include <round.h>
|
||||||
#include <stdio.h>
|
#include <stdio.h>
|
||||||
#include <stdlib.h>
|
#include <stdlib.h>
|
||||||
#include <string.h>
|
#include <string.h>
|
||||||
#include "userprog/gdt.h"
|
#include "userprog/gdt.h"
|
||||||
#include "userprog/pagedir.h"
|
#include "userprog/pagedir.h"
|
||||||
|
#include "userprog/syscall.h"
|
||||||
#include "userprog/tss.h"
|
#include "userprog/tss.h"
|
||||||
#include "filesys/directory.h"
|
#include "filesys/directory.h"
|
||||||
#include "filesys/file.h"
|
#include "filesys/file.h"
|
||||||
@@ -14,57 +17,172 @@
|
|||||||
#include "threads/flags.h"
|
#include "threads/flags.h"
|
||||||
#include "threads/init.h"
|
#include "threads/init.h"
|
||||||
#include "threads/interrupt.h"
|
#include "threads/interrupt.h"
|
||||||
|
#include "threads/synch.h"
|
||||||
#include "threads/palloc.h"
|
#include "threads/palloc.h"
|
||||||
|
#include "threads/malloc.h"
|
||||||
#include "threads/thread.h"
|
#include "threads/thread.h"
|
||||||
#include "threads/vaddr.h"
|
#include "threads/vaddr.h"
|
||||||
|
#include "threads/synch.h"
|
||||||
|
#include "devices/timer.h"
|
||||||
|
#ifdef VM
|
||||||
|
#include "vm/frame.h"
|
||||||
|
#endif
|
||||||
|
|
||||||
|
/* Defines the native number of bytes processed by the processor
|
||||||
|
(for the purposes of alignment). */
|
||||||
|
#define WORD_SIZE 4
|
||||||
|
|
||||||
|
/* Defines non-negative integer division wherein the result is always rounded
|
||||||
|
up. */
|
||||||
|
#define DIV_CEIL(x, y) ((x + (y - 1)) / y)
|
||||||
|
|
||||||
|
/* Keeps track of the position of pointers to user program arguments
|
||||||
|
within a linked list. */
|
||||||
|
struct arg_elem
|
||||||
|
{
|
||||||
|
char* arg;
|
||||||
|
struct list_elem elem;
|
||||||
|
};
|
||||||
|
|
||||||
|
/* Holds the data required to be passed from a kernel thread to a thread
|
||||||
|
that executes process_start for the purpose of starting a user process. */
|
||||||
|
struct process_start_data
|
||||||
|
{
|
||||||
|
char *cmd_saveptr; /* Value pointed to by 'saveptr' argument used by
|
||||||
|
successive calls to strtok_r to split 'cmd' into
|
||||||
|
tokens while maintaining state. */
|
||||||
|
char file_name[FNAME_MAX_LEN + 1]; /* Name of the file of the process to
|
||||||
|
be started. */
|
||||||
|
bool success; /* Indicates whether the process was successfully loaded. */
|
||||||
|
struct semaphore loaded; /* Semaphore used to signal that the process has
|
||||||
|
finished attempting to load. */
|
||||||
|
};
|
||||||
|
|
||||||
static thread_func start_process NO_RETURN;
|
static thread_func start_process NO_RETURN;
|
||||||
|
static void destruct_process_result (struct hash_elem *e, void *aux UNUSED);
|
||||||
static bool load (const char *cmdline, void (**eip) (void), void **esp);
|
static bool load (const char *cmdline, void (**eip) (void), void **esp);
|
||||||
|
|
||||||
/* Starts a new thread running a user program loaded from
|
/* Starts a new thread running a user program executed via
|
||||||
FILENAME. The new thread may be scheduled (and may even exit)
|
CMD. The new thread may be scheduled (and may even exit)
|
||||||
before process_execute() returns. Returns the new process's
|
before process_execute() returns. Returns the new process's
|
||||||
thread id, or TID_ERROR if the thread cannot be created. */
|
thread id, or TID_ERROR if the thread cannot be created. */
|
||||||
tid_t
|
tid_t
|
||||||
process_execute (const char *file_name)
|
process_execute (const char *cmd)
|
||||||
{
|
{
|
||||||
char *fn_copy;
|
char *cmd_copy;
|
||||||
tid_t tid;
|
tid_t tid;
|
||||||
|
struct process_start_data data;
|
||||||
|
|
||||||
/* Make a copy of FILE_NAME.
|
/* Make a copy of command.
|
||||||
Otherwise there's a race between the caller and load(). */
|
Otherwise there's a race between the caller and load(). */
|
||||||
fn_copy = palloc_get_page (0);
|
cmd_copy = palloc_get_page (0);
|
||||||
if (fn_copy == NULL)
|
if (cmd_copy == NULL)
|
||||||
return TID_ERROR;
|
return TID_ERROR;
|
||||||
strlcpy (fn_copy, file_name, PGSIZE);
|
|
||||||
|
|
||||||
/* Create a new thread to execute FILE_NAME. */
|
/* Imposing implicit limit that the command line arguments
|
||||||
tid = thread_create (file_name, PRI_DEFAULT, start_process, fn_copy);
|
including the user program name fit within a single page. */
|
||||||
if (tid == TID_ERROR)
|
strlcpy (cmd_copy, cmd, PGSIZE);
|
||||||
palloc_free_page (fn_copy);
|
|
||||||
|
/* Retrieve first argument of command, which is the file name
|
||||||
|
of the process. */
|
||||||
|
char *file_name = strtok_r (cmd_copy, " ", &data.cmd_saveptr);
|
||||||
|
|
||||||
|
/* Validates that the current file to be executed can be opened/exists. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
struct file *file = filesys_open (file_name);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
if (file == NULL)
|
||||||
|
return TID_ERROR;
|
||||||
|
|
||||||
|
/* Create a new thread to execute the command, by initializing
|
||||||
|
it running the function 'start_process' with the appropriate
|
||||||
|
arguments. For details of arguments, see 'start_process'. */
|
||||||
|
strlcpy (data.file_name, file_name, FNAME_MAX_LEN + 1);
|
||||||
|
sema_init (&data.loaded, 0);
|
||||||
|
data.success = false;
|
||||||
|
|
||||||
|
tid = thread_create (file_name, PRI_DEFAULT, start_process, &data);
|
||||||
|
|
||||||
|
/* Wait until process file has finished attempting to load via the child
|
||||||
|
thread before reporting success of starting execution. */
|
||||||
|
if (tid != TID_ERROR)
|
||||||
|
{
|
||||||
|
sema_down (&data.loaded);
|
||||||
|
if (!data.success)
|
||||||
|
tid = TID_ERROR;
|
||||||
|
}
|
||||||
|
|
||||||
|
palloc_free_page (cmd_copy);
|
||||||
return tid;
|
return tid;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* A thread function that loads a user process and starts it
|
static void *get_usr_kpage (enum palloc_flags flags, void *upage);
|
||||||
running. */
|
static void free_usr_kpage (void *kpage);
|
||||||
|
static bool install_page (void *upage, void *kpage, bool writable);
|
||||||
|
|
||||||
|
static bool process_init_stack (char *cmd_saveptr, void **esp, char *file_name);
|
||||||
|
static void *push_to_stack (void **esp, void *data, size_t data_size);
|
||||||
|
#define push_var_to_stack(esp, var) (push_to_stack (esp, &var, sizeof (var)))
|
||||||
|
|
||||||
|
/* Make the current thread execute 'cmd', passing in a copy of the
|
||||||
|
command string used for processing, the saveptr used by strtok_r
|
||||||
|
(in order to further tokenize the same command and retrieve its
|
||||||
|
arguments), the name of the file being executed, and a semaphore that
|
||||||
|
calls sema_up to indicate that the 'success' variable passed to it
|
||||||
|
has been updated to indicate whether the process file loading succeeded.
|
||||||
|
This involves loading the specified file and calling its main () function
|
||||||
|
with the specified command arguments. */
|
||||||
static void
|
static void
|
||||||
start_process (void *file_name_)
|
start_process (void *proc_start_data)
|
||||||
{
|
{
|
||||||
char *file_name = file_name_;
|
|
||||||
struct intr_frame if_;
|
struct intr_frame if_;
|
||||||
bool success;
|
struct process_start_data *data = proc_start_data;
|
||||||
|
|
||||||
/* Initialize interrupt frame and load executable. */
|
/* Initialize interrupt frame and load executable. */
|
||||||
memset (&if_, 0, sizeof if_);
|
memset (&if_, 0, sizeof if_);
|
||||||
if_.gs = if_.fs = if_.es = if_.ds = if_.ss = SEL_UDSEG;
|
if_.gs = if_.fs = if_.es = if_.ds = if_.ss = SEL_UDSEG;
|
||||||
if_.cs = SEL_UCSEG;
|
if_.cs = SEL_UCSEG;
|
||||||
if_.eflags = FLAG_IF | FLAG_MBS;
|
if_.eflags = FLAG_IF | FLAG_MBS;
|
||||||
success = load (file_name, &if_.eip, &if_.esp);
|
|
||||||
|
|
||||||
/* If load failed, quit. */
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
palloc_free_page (file_name);
|
lock_acquire (&filesys_lock);
|
||||||
if (!success)
|
|
||||||
thread_exit ();
|
struct file *exec_file = filesys_open (data->file_name);
|
||||||
|
if (exec_file == NULL)
|
||||||
|
{
|
||||||
|
/* If the executable file cannot be opened, free resources and quit. */
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
sema_up (&data->loaded);
|
||||||
|
thread_exit ();
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Deny write to the executable file to prevent writing to it and release the
|
||||||
|
file system lock. */
|
||||||
|
file_deny_write (exec_file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
thread_current ()->exec_file = exec_file;
|
||||||
|
|
||||||
|
/* Load the ELF executable file, and store the success of the operation in
|
||||||
|
the 'success' variable in data. */
|
||||||
|
data->success = load (data->file_name, &if_.eip, &if_.esp);
|
||||||
|
|
||||||
|
/* If load was sucessful, initialize user process stack and free page used
|
||||||
|
to store the command that executed the process. */
|
||||||
|
if (data->success)
|
||||||
|
{
|
||||||
|
data->success =
|
||||||
|
process_init_stack (data->cmd_saveptr, &if_.esp, data->file_name);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Signal that the process has finished attempting to load. */
|
||||||
|
bool success = data->success;
|
||||||
|
sema_up (&data->loaded);
|
||||||
|
|
||||||
|
/* If the load was unsuccessful or if it was but the stack initialization
|
||||||
|
failed, exit the thread. */
|
||||||
|
if (!success)
|
||||||
|
thread_exit ();
|
||||||
|
|
||||||
/* Start the user process by simulating a return from an
|
/* Start the user process by simulating a return from an
|
||||||
interrupt, implemented by intr_exit (in
|
interrupt, implemented by intr_exit (in
|
||||||
@@ -76,6 +194,124 @@ start_process (void *file_name_)
|
|||||||
NOT_REACHED ();
|
NOT_REACHED ();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Helper function that initializes the stack of a newly created
|
||||||
|
user process. Returns true if successful, false otherwise. */
|
||||||
|
static bool
|
||||||
|
process_init_stack (char *cmd_saveptr, void **esp, char *file_name)
|
||||||
|
{
|
||||||
|
ASSERT (cmd_saveptr != NULL);
|
||||||
|
ASSERT (esp != NULL);
|
||||||
|
ASSERT (file_name != NULL);
|
||||||
|
|
||||||
|
/* Load command line argument *data* to user process stack.
|
||||||
|
This can't cause overflow due to enforcing that the size of
|
||||||
|
command line input must fit in a page. Also keep track
|
||||||
|
of pointers to the argument data within a linked list. */
|
||||||
|
struct list arg_list;
|
||||||
|
list_init (&arg_list);
|
||||||
|
|
||||||
|
char *arg = file_name;
|
||||||
|
int arg_count = 0;
|
||||||
|
while (arg != NULL)
|
||||||
|
{
|
||||||
|
/* filename has already been validated to be a safe-to-access string,
|
||||||
|
so we can safely use strlen here. Filename has already been
|
||||||
|
split from the command line arguments. */
|
||||||
|
push_to_stack (esp, arg, (strlen (arg) + 1) * sizeof (char));
|
||||||
|
|
||||||
|
/* Try to allocate memory for the argument pointer. */
|
||||||
|
struct arg_elem *arg_elem = malloc (sizeof (struct arg_elem));
|
||||||
|
if (arg_elem == NULL)
|
||||||
|
{
|
||||||
|
printf("ERROR: Couldn't allocate argument pointer memory for %s!\n",
|
||||||
|
thread_current ()->name);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Store the argument pointer in the linked list. */
|
||||||
|
arg_elem->arg = *esp;
|
||||||
|
list_push_front (&arg_list, &arg_elem->elem);
|
||||||
|
|
||||||
|
/* Increment the argument count and get the next argument. */
|
||||||
|
arg_count++;
|
||||||
|
arg = strtok_r (NULL, " ", &cmd_saveptr);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Calculate the remaining number of bytes that need to be written
|
||||||
|
to the user process stack in order to check for possible overflow. */
|
||||||
|
size_t align_size = ((unsigned int) *esp % WORD_SIZE) * sizeof (uint8_t);
|
||||||
|
size_t argv_data_size = (arg_count + 1) * sizeof (char *);
|
||||||
|
size_t argv_size = sizeof (char **);
|
||||||
|
size_t argc_size = sizeof (int);
|
||||||
|
size_t return_addr_size = sizeof (void *);
|
||||||
|
size_t remaining_size = align_size + argv_data_size + argv_size + argc_size
|
||||||
|
+ return_addr_size;
|
||||||
|
|
||||||
|
/* If pushing the rest of the data required for the stack would cause
|
||||||
|
overflow, allocate as many extra pages as needed to the user process
|
||||||
|
contiguously in the virtual address space below the initial page. */
|
||||||
|
int overflow_bytes = (PHYS_BASE - *esp) + remaining_size - PGSIZE;
|
||||||
|
if (overflow_bytes > 0)
|
||||||
|
{
|
||||||
|
/* Calculate the number of pages needed to allocate. */
|
||||||
|
int pages_needed = DIV_CEIL (overflow_bytes, PGSIZE);
|
||||||
|
|
||||||
|
/* Allocate the pages and map them to the user process. */
|
||||||
|
void *upage;
|
||||||
|
uint8_t *kpage;
|
||||||
|
for (int i = 1; i < pages_needed + 1; i++)
|
||||||
|
{
|
||||||
|
upage = ((uint8_t *) PHYS_BASE) - PGSIZE * (i + 1);
|
||||||
|
kpage = get_usr_kpage (PAL_ZERO, upage);
|
||||||
|
if (!install_page (upage, kpage, true)) return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Align stack pointer to word size before pushing argv elements for
|
||||||
|
performance. */
|
||||||
|
*esp -= align_size;
|
||||||
|
|
||||||
|
/* Push a null pointer sentinel inside argv. */
|
||||||
|
char *null_sentinel = NULL;
|
||||||
|
push_var_to_stack (esp, null_sentinel);
|
||||||
|
|
||||||
|
/* Push pointers to process arguments from argument linked list */
|
||||||
|
struct list_elem *e = list_begin (&arg_list);
|
||||||
|
struct list_elem *tail = list_tail (&arg_list);
|
||||||
|
while (e != tail)
|
||||||
|
{
|
||||||
|
struct arg_elem *arg_elem = list_entry (e, struct arg_elem, elem);
|
||||||
|
|
||||||
|
push_var_to_stack(esp, arg_elem->arg);
|
||||||
|
|
||||||
|
e = list_next (e);
|
||||||
|
free (arg_elem);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Push pointer to the start of argv array. */
|
||||||
|
char **argv = *esp;
|
||||||
|
push_var_to_stack(esp, argv);
|
||||||
|
|
||||||
|
/* Push the number of arguments to the stack. */
|
||||||
|
push_var_to_stack(esp, arg_count);
|
||||||
|
|
||||||
|
/* Push fake return address (null pointer). */
|
||||||
|
push_var_to_stack (esp, null_sentinel);
|
||||||
|
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Helper function that pushes the first 'data_size' bytes stored
|
||||||
|
in the address '*data' into the stack given a pointer to the
|
||||||
|
stack pointer '**esp'. */
|
||||||
|
static void *
|
||||||
|
push_to_stack (void **esp, void *data, size_t data_size)
|
||||||
|
{
|
||||||
|
*esp -= data_size;
|
||||||
|
memcpy (*esp, data, data_size);
|
||||||
|
return *esp;
|
||||||
|
}
|
||||||
|
|
||||||
/* Waits for thread TID to die and returns its exit status.
|
/* Waits for thread TID to die and returns its exit status.
|
||||||
* If it was terminated by the kernel (i.e. killed due to an exception),
|
* If it was terminated by the kernel (i.e. killed due to an exception),
|
||||||
* returns -1.
|
* returns -1.
|
||||||
@@ -86,9 +322,37 @@ start_process (void *file_name_)
|
|||||||
* This function will be implemented in task 2.
|
* This function will be implemented in task 2.
|
||||||
* For now, it does nothing. */
|
* For now, it does nothing. */
|
||||||
int
|
int
|
||||||
process_wait (tid_t child_tid UNUSED)
|
process_wait (tid_t child_tid)
|
||||||
{
|
{
|
||||||
return -1;
|
struct thread *t = thread_current ();
|
||||||
|
struct process_result fake_result;
|
||||||
|
fake_result.tid = child_tid;
|
||||||
|
struct hash_elem *e = hash_find (&t->child_results, &fake_result.elem);
|
||||||
|
if (e == NULL)
|
||||||
|
return -1;
|
||||||
|
|
||||||
|
struct process_result *child_result
|
||||||
|
= hash_entry (e, struct process_result, elem);
|
||||||
|
/* Wait for child to die. */
|
||||||
|
sema_down (&child_result->sema);
|
||||||
|
|
||||||
|
/* We need lock release in process_exit, so we need to acquire (and possibly
|
||||||
|
wait) for it here to ensure we don't free the lock memory before it is
|
||||||
|
released in process_exit. */
|
||||||
|
lock_acquire (&child_result->lock);
|
||||||
|
/* To prevent waiting for child twice, remove it from the table.
|
||||||
|
No need to use lock since this is the only thread with access to
|
||||||
|
the struct process_result now. */
|
||||||
|
hash_delete (&t->child_results, &child_result->elem);
|
||||||
|
|
||||||
|
/* Get the exit status of the child */
|
||||||
|
int exit_status = child_result->exit_status;
|
||||||
|
|
||||||
|
/* Release the lock */
|
||||||
|
lock_release (&child_result->lock);
|
||||||
|
/* Result no-longer used by parent, nor child. Deallocate it. */
|
||||||
|
free (child_result);
|
||||||
|
return exit_status;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Free the current process's resources. */
|
/* Free the current process's resources. */
|
||||||
@@ -98,6 +362,28 @@ process_exit (void)
|
|||||||
struct thread *cur = thread_current ();
|
struct thread *cur = thread_current ();
|
||||||
uint32_t *pd;
|
uint32_t *pd;
|
||||||
|
|
||||||
|
/* Clean up all open files */
|
||||||
|
hash_destroy (&cur->open_files, fd_cleanup);
|
||||||
|
|
||||||
|
/* Close the executable file, implicitly allowing it to be written to. */
|
||||||
|
if (cur->exec_file != NULL)
|
||||||
|
{
|
||||||
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
file_close (cur->exec_file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (cur->result != NULL)
|
||||||
|
{
|
||||||
|
printf ("%s: exit(%d)\n", cur->name, cur->result->exit_status);
|
||||||
|
/* Update own process result. */
|
||||||
|
destruct_process_result (&cur->result->elem, cur);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Free child process results or signal parent's death. */
|
||||||
|
hash_destroy (&cur->child_results, destruct_process_result);
|
||||||
|
|
||||||
/* Destroy the current process's page directory and switch back
|
/* Destroy the current process's page directory and switch back
|
||||||
to the kernel-only page directory. */
|
to the kernel-only page directory. */
|
||||||
pd = cur->pagedir;
|
pd = cur->pagedir;
|
||||||
@@ -116,6 +402,28 @@ process_exit (void)
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Destruct a process_result, with multi-thread awareness.
|
||||||
|
If the other thread is running, simply signals death. Otherwise
|
||||||
|
frees the result. */
|
||||||
|
static void
|
||||||
|
destruct_process_result (struct hash_elem *e, void *aux UNUSED)
|
||||||
|
{
|
||||||
|
struct process_result *result = hash_entry (e, struct process_result, elem);
|
||||||
|
lock_acquire (&result->lock);
|
||||||
|
/* Other thread has died (and was not waited for). Free the result. */
|
||||||
|
if (sema_try_down (&result->sema))
|
||||||
|
{
|
||||||
|
lock_release (&result->lock);
|
||||||
|
free (result);
|
||||||
|
}
|
||||||
|
/* Other thread is still alive, signal via sema that parent has died. */
|
||||||
|
else
|
||||||
|
{
|
||||||
|
sema_up (&result->sema);
|
||||||
|
lock_release (&result->lock);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/* Sets up the CPU for running user code in the current
|
/* Sets up the CPU for running user code in the current
|
||||||
thread.
|
thread.
|
||||||
This function is called on every context switch. */
|
This function is called on every context switch. */
|
||||||
@@ -214,6 +522,7 @@ load (const char *file_name, void (**eip) (void), void **esp)
|
|||||||
off_t file_ofs;
|
off_t file_ofs;
|
||||||
bool success = false;
|
bool success = false;
|
||||||
int i;
|
int i;
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
|
||||||
/* Allocate and activate page directory. */
|
/* Allocate and activate page directory. */
|
||||||
t->pagedir = pagedir_create ();
|
t->pagedir = pagedir_create ();
|
||||||
@@ -313,13 +622,12 @@ load (const char *file_name, void (**eip) (void), void **esp)
|
|||||||
done:
|
done:
|
||||||
/* We arrive here whether the load is successful or not. */
|
/* We arrive here whether the load is successful or not. */
|
||||||
file_close (file);
|
file_close (file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
return success;
|
return success;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* load() helpers. */
|
/* load() helpers. */
|
||||||
|
|
||||||
static bool install_page (void *upage, void *kpage, bool writable);
|
|
||||||
|
|
||||||
/* Checks whether PHDR describes a valid, loadable segment in
|
/* Checks whether PHDR describes a valid, loadable segment in
|
||||||
FILE and returns true if so, false otherwise. */
|
FILE and returns true if so, false otherwise. */
|
||||||
static bool
|
static bool
|
||||||
@@ -403,7 +711,7 @@ load_segment (struct file *file, off_t ofs, uint8_t *upage,
|
|||||||
if (kpage == NULL){
|
if (kpage == NULL){
|
||||||
|
|
||||||
/* Get a new page of memory. */
|
/* Get a new page of memory. */
|
||||||
kpage = palloc_get_page (PAL_USER);
|
kpage = get_usr_kpage (0, upage);
|
||||||
if (kpage == NULL){
|
if (kpage == NULL){
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
@@ -411,7 +719,7 @@ load_segment (struct file *file, off_t ofs, uint8_t *upage,
|
|||||||
/* Add the page to the process's address space. */
|
/* Add the page to the process's address space. */
|
||||||
if (!install_page (upage, kpage, writable))
|
if (!install_page (upage, kpage, writable))
|
||||||
{
|
{
|
||||||
palloc_free_page (kpage);
|
free_usr_kpage (kpage);
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -445,19 +753,53 @@ setup_stack (void **esp)
|
|||||||
{
|
{
|
||||||
uint8_t *kpage;
|
uint8_t *kpage;
|
||||||
bool success = false;
|
bool success = false;
|
||||||
|
|
||||||
kpage = palloc_get_page (PAL_USER | PAL_ZERO);
|
void *upage = ((uint8_t *) PHYS_BASE) - PGSIZE;
|
||||||
|
|
||||||
|
kpage = get_usr_kpage (PAL_ZERO, upage);
|
||||||
if (kpage != NULL)
|
if (kpage != NULL)
|
||||||
{
|
{
|
||||||
success = install_page (((uint8_t *) PHYS_BASE) - PGSIZE, kpage, true);
|
success = install_page (upage, kpage, true);
|
||||||
if (success)
|
if (success)
|
||||||
*esp = PHYS_BASE;
|
*esp = PHYS_BASE;
|
||||||
else
|
else
|
||||||
palloc_free_page (kpage);
|
free_usr_kpage (kpage);
|
||||||
}
|
}
|
||||||
return success;
|
return success;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Claims a page from the user pool for ownership by the current thread
|
||||||
|
and returns its kernel address, updating the frame table if VM
|
||||||
|
is enabled. Requires the intended virtual address for where the page
|
||||||
|
will be installed. */
|
||||||
|
static void *
|
||||||
|
get_usr_kpage (enum palloc_flags flags, void *upage)
|
||||||
|
{
|
||||||
|
void *page;
|
||||||
|
#ifdef VM
|
||||||
|
struct thread *t = thread_current ();
|
||||||
|
if (pagedir_get_page (t->pagedir, upage) != NULL)
|
||||||
|
return NULL;
|
||||||
|
else
|
||||||
|
page = frame_alloc (flags, upage, t);
|
||||||
|
#else
|
||||||
|
page = palloc_get_page (flags | PAL_USER);
|
||||||
|
#endif
|
||||||
|
return page;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Frees a page belonging to a user process given its kernel address,
|
||||||
|
updating the frame table if VM is enabled. */
|
||||||
|
static void
|
||||||
|
free_usr_kpage (void *kpage)
|
||||||
|
{
|
||||||
|
#ifdef VM
|
||||||
|
frame_free (kpage);
|
||||||
|
#else
|
||||||
|
palloc_free_page (kpage);
|
||||||
|
#endif
|
||||||
|
}
|
||||||
|
|
||||||
/* Adds a mapping from user virtual address UPAGE to kernel
|
/* Adds a mapping from user virtual address UPAGE to kernel
|
||||||
virtual address KPAGE to the page table.
|
virtual address KPAGE to the page table.
|
||||||
If WRITABLE is true, the user process may modify the page;
|
If WRITABLE is true, the user process may modify the page;
|
||||||
|
|||||||
@@ -1,20 +1,539 @@
|
|||||||
#include "userprog/syscall.h"
|
#include "userprog/syscall.h"
|
||||||
#include <stdio.h>
|
#include "devices/shutdown.h"
|
||||||
#include <syscall-nr.h>
|
#include "devices/input.h"
|
||||||
|
#include "filesys/file.h"
|
||||||
|
#include "filesys/filesys.h"
|
||||||
|
#include "threads/vaddr.h"
|
||||||
#include "threads/interrupt.h"
|
#include "threads/interrupt.h"
|
||||||
|
#include "threads/malloc.h"
|
||||||
#include "threads/thread.h"
|
#include "threads/thread.h"
|
||||||
|
#include "threads/synch.h"
|
||||||
|
#include "userprog/process.h"
|
||||||
|
#include "userprog/pagedir.h"
|
||||||
|
#include <stdio.h>
|
||||||
|
#include <stdbool.h>
|
||||||
|
#include <syscall-nr.h>
|
||||||
|
|
||||||
|
#define MAX_SYSCALL_ARGS 3
|
||||||
|
#define EXIT_FAILURE -1
|
||||||
|
|
||||||
|
struct open_file
|
||||||
|
{
|
||||||
|
int fd; /* File Descriptor / Identifier */
|
||||||
|
struct file *file; /* Pointer to the associated file */
|
||||||
|
struct hash_elem elem; /* elem for a hash table */
|
||||||
|
};
|
||||||
|
|
||||||
static void syscall_handler (struct intr_frame *);
|
static void syscall_handler (struct intr_frame *);
|
||||||
|
|
||||||
|
/* A syscall_function is a function that receives up to 3 arguments, the
|
||||||
|
arguments to the functions are either ints or pointers taking up to 32 bits
|
||||||
|
in size. */
|
||||||
|
typedef uintptr_t (*syscall_function) (uintptr_t, uintptr_t, uintptr_t);
|
||||||
|
|
||||||
|
/* System call function prototypes */
|
||||||
|
static void syscall_halt (void);
|
||||||
|
static void syscall_exit (int status);
|
||||||
|
static pid_t syscall_exec (const char *cmd_line);
|
||||||
|
static int syscall_wait (pid_t pid);
|
||||||
|
static bool syscall_create (const char *file, unsigned initial_size);
|
||||||
|
static bool syscall_remove (const char *file);
|
||||||
|
static int syscall_open (const char *file);
|
||||||
|
static int syscall_filesize (int fd);
|
||||||
|
static int syscall_read (int fd, void *buffer, unsigned size);
|
||||||
|
static int syscall_write (int fd, const void *buffer, unsigned size);
|
||||||
|
static void syscall_seek (int fd, unsigned position);
|
||||||
|
static unsigned syscall_tell (int fd);
|
||||||
|
static void syscall_close (int fd);
|
||||||
|
|
||||||
|
static struct open_file *fd_get_file (int fd);
|
||||||
|
static void validate_user_pointer (const void *ptr, size_t size,
|
||||||
|
bool check_write);
|
||||||
|
static void validate_user_string (const char *str, bool check_write);
|
||||||
|
static int get_user (const uint8_t *);
|
||||||
|
static bool put_user (uint8_t *, uint8_t);
|
||||||
|
|
||||||
|
/* A struct defining a syscall_function pointer along with its arity. */
|
||||||
|
struct syscall_arguments
|
||||||
|
{
|
||||||
|
syscall_function function; /* Function pointer. */
|
||||||
|
int arity; /* Number of arguments of the function. */
|
||||||
|
};
|
||||||
|
|
||||||
|
/* A look-up table mapping numbers to system call functions with their number of
|
||||||
|
arguments. */
|
||||||
|
static const struct syscall_arguments syscall_lookup[] =
|
||||||
|
{
|
||||||
|
[SYS_HALT] = {(syscall_function) syscall_halt, 0},
|
||||||
|
[SYS_EXIT] = {(syscall_function) syscall_exit, 1},
|
||||||
|
[SYS_EXEC] = {(syscall_function) syscall_exec, 1},
|
||||||
|
[SYS_WAIT] = {(syscall_function) syscall_wait, 1},
|
||||||
|
[SYS_CREATE] = {(syscall_function) syscall_create, 2},
|
||||||
|
[SYS_REMOVE] = {(syscall_function) syscall_remove, 1},
|
||||||
|
[SYS_OPEN] = {(syscall_function) syscall_open, 1},
|
||||||
|
[SYS_FILESIZE] = {(syscall_function) syscall_filesize, 1},
|
||||||
|
[SYS_READ] = {(syscall_function) syscall_read, 3},
|
||||||
|
[SYS_WRITE] = {(syscall_function) syscall_write, 3},
|
||||||
|
[SYS_SEEK] = {(syscall_function) syscall_seek, 2},
|
||||||
|
[SYS_TELL] = {(syscall_function) syscall_tell, 1},
|
||||||
|
[SYS_CLOSE] = {(syscall_function) syscall_close, 1},
|
||||||
|
};
|
||||||
|
|
||||||
|
/* The number of syscall functions (i.e, number of elements) within the
|
||||||
|
syscall_lookup table. */
|
||||||
|
static const int LOOKUP_SIZE
|
||||||
|
= sizeof (syscall_lookup) / sizeof (struct syscall_arguments);
|
||||||
|
|
||||||
|
/* Initialises the syscall handling system, as well as a global lock to
|
||||||
|
synchronise all file access between processes. */
|
||||||
void
|
void
|
||||||
syscall_init (void)
|
syscall_init (void)
|
||||||
{
|
{
|
||||||
intr_register_int (0x30, 3, INTR_ON, syscall_handler, "syscall");
|
intr_register_int (0x30, 3, INTR_ON, syscall_handler, "syscall");
|
||||||
|
lock_init (&filesys_lock);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Function that takes an interrupt frame containing a syscall and its args.
|
||||||
|
Validates the arguments and pointers before calling the relevant
|
||||||
|
high-level system call function, storing its output (if any) in f->eax */
|
||||||
|
static void
|
||||||
|
syscall_handler (struct intr_frame *f)
|
||||||
|
{
|
||||||
|
/* First, read the system call number from the stack. */
|
||||||
|
validate_user_pointer (f->esp, sizeof (uintptr_t), false);
|
||||||
|
uintptr_t syscall_number = *(int *)f->esp;
|
||||||
|
thread_current ()->curr_esp = f->esp;
|
||||||
|
|
||||||
|
/* Ensures the number corresponds to a system call that can be handled. */
|
||||||
|
if (syscall_number >= LOOKUP_SIZE)
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
|
||||||
|
struct syscall_arguments syscall = syscall_lookup[syscall_number];
|
||||||
|
|
||||||
|
/* Next, read and copy the arguments from the stack pointer. */
|
||||||
|
validate_user_pointer (f->esp + sizeof (uintptr_t),
|
||||||
|
syscall.arity * sizeof (uintptr_t), false);
|
||||||
|
uintptr_t args[MAX_SYSCALL_ARGS] = { 0 };
|
||||||
|
for (int i = 0; i < syscall.arity && i < MAX_SYSCALL_ARGS; i++)
|
||||||
|
args[i] = *(uintptr_t *)(f->esp + sizeof (uintptr_t) * (i + 1));
|
||||||
|
|
||||||
|
/* Call the function that handles this system call with the arguments. When
|
||||||
|
there is a return value it is stored in f->eax. */
|
||||||
|
f->eax = syscall.function (args[0], args[1], args[2]);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Called upon a "halt" syscall, resulting in a complete shutdown of the
|
||||||
|
process, via shutdown_power_off (); */
|
||||||
|
static void
|
||||||
|
syscall_halt (void)
|
||||||
|
{
|
||||||
|
shutdown_power_off ();
|
||||||
}
|
}
|
||||||
|
|
||||||
static void
|
static void
|
||||||
syscall_handler (struct intr_frame *f UNUSED)
|
syscall_exit (int status)
|
||||||
{
|
{
|
||||||
printf ("system call!\n");
|
/* Sets exit_status of the thread to status. thread_exit () will call
|
||||||
|
process_exit () if user programs are allowed. */
|
||||||
|
thread_current ()->result->exit_status = status;
|
||||||
thread_exit ();
|
thread_exit ();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Executes a given command with the relevant args, by calling process_execute.
|
||||||
|
Returns PID for the process that is running the CMD_LINE. */
|
||||||
|
static pid_t
|
||||||
|
syscall_exec (const char *cmd_line)
|
||||||
|
{
|
||||||
|
validate_user_string (cmd_line, false);
|
||||||
|
|
||||||
|
return process_execute (cmd_line); /* Returns the PID of the new process */
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall of wait. Effectively a wrapper for process_wait as the
|
||||||
|
necessary validation and such all happens in process_wait anyway. */
|
||||||
|
static int
|
||||||
|
syscall_wait (pid_t pid)
|
||||||
|
{
|
||||||
|
return process_wait (pid); /* Returns the exit status of the waited process */
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for file creation. First validates the user file
|
||||||
|
pointer. Acquires the file system lock to prevent synchronisation issues,
|
||||||
|
and then uses FILESYS_CREATE to create the file, returning the same status */
|
||||||
|
static bool
|
||||||
|
syscall_create (const char *file, unsigned initial_size)
|
||||||
|
{
|
||||||
|
validate_user_string (file, false);
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
bool status = filesys_create (file, initial_size);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Return the status of the file creation. */
|
||||||
|
return status;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for file removal. First validates the user file pointer.
|
||||||
|
Acquires the file system lock to prevent synchronisation issues, and then
|
||||||
|
uses FILESYS_REMOVE to remove the file, returning the same success status */
|
||||||
|
static bool
|
||||||
|
syscall_remove (const char *file)
|
||||||
|
{
|
||||||
|
validate_user_string (file, false);
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
bool status = filesys_remove (file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Return the status of the file removal. */
|
||||||
|
return status;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for opening a file connection. First, validates the file
|
||||||
|
pointer. Then it acquires a lock for the file system, in order to open the
|
||||||
|
connection without synchronisation issues. It then maps a new fd to this file
|
||||||
|
in the hash table before returning the fd. */
|
||||||
|
static int
|
||||||
|
syscall_open (const char *file)
|
||||||
|
{
|
||||||
|
validate_user_string (file, false);
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
struct file *ptr = filesys_open (file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* If the file could not be opened, return failure. */
|
||||||
|
if (ptr == NULL)
|
||||||
|
return EXIT_FAILURE;
|
||||||
|
|
||||||
|
/* Allocate space for a struct representing a mapping from an FD to a struct
|
||||||
|
file. */
|
||||||
|
struct open_file *file_info
|
||||||
|
= (struct open_file*) malloc (sizeof (struct open_file));
|
||||||
|
if (file_info == NULL)
|
||||||
|
{
|
||||||
|
/* If we could not allocate memory for the file_info struct, close the
|
||||||
|
file and return failure. */
|
||||||
|
file_close (ptr);
|
||||||
|
return EXIT_FAILURE;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Populate the above struct, with a unique FD and the current open file */
|
||||||
|
file_info->fd = thread_current ()->fd_counter++;
|
||||||
|
file_info->file = ptr;
|
||||||
|
|
||||||
|
/* Add the new FD->file mapping to the hashtable for the current thread */
|
||||||
|
hash_insert (&thread_current ()->open_files, &file_info->elem);
|
||||||
|
|
||||||
|
/* Return the new FD */
|
||||||
|
return file_info->fd;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for getting a file's size. Converts a provided FD into
|
||||||
|
the asssociated file struct. Acquire the lock for the filesystem and use
|
||||||
|
FILE_LENGTH to calculate the length for return. */
|
||||||
|
static int
|
||||||
|
syscall_filesize (int fd)
|
||||||
|
{
|
||||||
|
/* Try to get the file from the FD. If it does not exist, return failure. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info == NULL)
|
||||||
|
return EXIT_FAILURE;
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent any race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
int bytes = file_length (file_info->file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Return the number of bytes in the file. */
|
||||||
|
return bytes;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for reading SIZE bytes from a file referenced by FD.
|
||||||
|
If the FD references the console, use input_getc (), otherwise convert the
|
||||||
|
FD to its associated file struct, acquire the filesystem lock, read up to
|
||||||
|
SIZE bytes and then return the number of bytes read.*/
|
||||||
|
static int
|
||||||
|
syscall_read (int fd, void *buffer, unsigned size)
|
||||||
|
{
|
||||||
|
/* Only console (fd = 0) or other files, not including STDOUT, (fd > 1) are
|
||||||
|
allowed. */
|
||||||
|
if (fd < STDIN_FILENO || fd == STDOUT_FILENO)
|
||||||
|
return EXIT_FAILURE;
|
||||||
|
|
||||||
|
validate_user_pointer (buffer, size, true);
|
||||||
|
|
||||||
|
if (fd == STDIN_FILENO)
|
||||||
|
{
|
||||||
|
/* Reading from the console. */
|
||||||
|
char *write_buffer = buffer;
|
||||||
|
for (unsigned i = 0; i < size; i++)
|
||||||
|
write_buffer[i] = input_getc ();
|
||||||
|
|
||||||
|
/* In case of console, read is always (eventually) successful. So return
|
||||||
|
the size for the number of bytes read. */
|
||||||
|
return size;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
/* Reading from a file. */
|
||||||
|
/* Find the file from the FD. If it does not exist, return failure. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info == NULL)
|
||||||
|
return EXIT_FAILURE;
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent race-conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
int bytes_written = file_read (file_info->file, buffer, size);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Return the number of bytes read. */
|
||||||
|
return bytes_written;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for writing SIZE bytes to a file referenced by FD.
|
||||||
|
If the FD references the console, use put_buf (), otherwise convert the
|
||||||
|
FD to its associated file struct, acquire the filesystem lock, write up to
|
||||||
|
SIZE bytes and then return the number of bytes written.*/
|
||||||
|
static int
|
||||||
|
syscall_write (int fd, const void *buffer, unsigned size)
|
||||||
|
{
|
||||||
|
/* Only console (fd = 1) or other files, not including STDIN, (fd > 1) are
|
||||||
|
allowed. */
|
||||||
|
if (fd <= 0)
|
||||||
|
return 0;
|
||||||
|
|
||||||
|
validate_user_pointer (buffer, size, false);
|
||||||
|
|
||||||
|
if (fd == STDOUT_FILENO)
|
||||||
|
{
|
||||||
|
/* Writing to the console. */
|
||||||
|
putbuf (buffer, size);
|
||||||
|
|
||||||
|
/* In case of console, write is always successful. So return the size for
|
||||||
|
the number of bytes written. */
|
||||||
|
return size;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
/* Writing to a file. */
|
||||||
|
/* Find the file from the FD. If it does not exist, return failure. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info == NULL)
|
||||||
|
return 0;
|
||||||
|
|
||||||
|
/* Acquire the file system lock to prevent race conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
int bytes = file_write (file_info->file, buffer, size);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Return the number of bytes written. */
|
||||||
|
return bytes;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for seeking to POSITION bytes in a file referenced by
|
||||||
|
FD. Converts the FD to its associated file struct, acquires the filesystem
|
||||||
|
lock and then uses file_seek to adjust the cursor to a specific position in
|
||||||
|
the file.*/
|
||||||
|
static void
|
||||||
|
syscall_seek (int fd, unsigned position)
|
||||||
|
{
|
||||||
|
/* Find the file from the FD. If it does not exist, do nothing. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info != NULL)
|
||||||
|
file_seek (file_info->file, position);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for returning the next byte in a file referenced by
|
||||||
|
FD. Converts the FD to its associated file struct, acquires the filesystem
|
||||||
|
lock and then uses file_tell to read the next byte.*/
|
||||||
|
static unsigned
|
||||||
|
syscall_tell (int fd)
|
||||||
|
{
|
||||||
|
/* Find the file from the FD. If it does not exist, return 0. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info == NULL)
|
||||||
|
return 0;
|
||||||
|
|
||||||
|
unsigned pos = file_tell (file_info->file);
|
||||||
|
|
||||||
|
/* Return the current position in the file. */
|
||||||
|
return pos;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Handles the syscall for closing a connection to a file. Converts the FD to
|
||||||
|
its associated file struct. If it exists, it removes it from the hash table,
|
||||||
|
acquires the filesystem lock, and uses file_close to close the connection.*/
|
||||||
|
static void
|
||||||
|
syscall_close (int fd)
|
||||||
|
{
|
||||||
|
/* Find the file from the FD. If it does not exist, do nothing. */
|
||||||
|
struct open_file *file_info = fd_get_file (fd);
|
||||||
|
if (file_info != NULL)
|
||||||
|
{
|
||||||
|
/* File exists */
|
||||||
|
/* First, remove the file from the hash table of open files. */
|
||||||
|
hash_delete (&thread_current ()->open_files, &file_info->elem);
|
||||||
|
|
||||||
|
/* Then, close the file, acquiring the file system lock to prevent race
|
||||||
|
conditions. */
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
file_close (file_info->file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
/* Free the memory allocated for the file_info struct. */
|
||||||
|
free (file_info);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Hashing function needed for the open_file table. Returns a hash for an entry,
|
||||||
|
based on its FD. */
|
||||||
|
unsigned
|
||||||
|
fd_hash (const struct hash_elem *element, void *aux UNUSED)
|
||||||
|
{
|
||||||
|
/* We use the FD as the hash value. This is because the FD is incremented
|
||||||
|
sequentially and is therefore unique for each file. It positively affects
|
||||||
|
the performance of the hash table: 1. It is unique so no need to call
|
||||||
|
expensive hash functions. 2. It being sequential means that the hash table
|
||||||
|
is more likely to be weight balanced. */
|
||||||
|
return hash_entry (element, struct open_file, elem)->fd;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Comparator function for the open_file table. Compares two entries based on
|
||||||
|
the FDs. */
|
||||||
|
bool
|
||||||
|
fd_less (const struct hash_elem *a_, const struct hash_elem *b_,
|
||||||
|
void *aux UNUSED)
|
||||||
|
{
|
||||||
|
struct open_file *a = hash_entry (a_, struct open_file, elem);
|
||||||
|
struct open_file *b = hash_entry (b_, struct open_file, elem);
|
||||||
|
|
||||||
|
return a->fd < b->fd;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Function to clean up an open file entry. Closes the file and frees the
|
||||||
|
associated memory. */
|
||||||
|
void
|
||||||
|
fd_cleanup (struct hash_elem *e, void *aux UNUSED)
|
||||||
|
{
|
||||||
|
struct open_file *file_info = hash_entry (e, struct open_file, elem);
|
||||||
|
|
||||||
|
lock_acquire (&filesys_lock);
|
||||||
|
file_close (file_info->file);
|
||||||
|
lock_release (&filesys_lock);
|
||||||
|
|
||||||
|
free (file_info);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Gets a file from its descriptor (FD number). If there is no file with the fd
|
||||||
|
FD it returns NULL. */
|
||||||
|
static struct open_file *
|
||||||
|
fd_get_file (int fd)
|
||||||
|
{
|
||||||
|
/* We have to set up a fake open_file in order to be able to search the hash
|
||||||
|
table. See hash.h. */
|
||||||
|
struct open_file fake_file_info;
|
||||||
|
fake_file_info.fd = fd;
|
||||||
|
|
||||||
|
struct hash_elem *e
|
||||||
|
= hash_find (&thread_current ()->open_files, &fake_file_info.elem);
|
||||||
|
|
||||||
|
if (e == NULL)
|
||||||
|
return NULL;
|
||||||
|
|
||||||
|
return hash_entry (e, struct open_file, elem);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Validates if a block of memory starting at PTR and of size SIZE bytes is
|
||||||
|
fully contained within valid user virtual memory. thread_exit () if the
|
||||||
|
memory is invalid.
|
||||||
|
If the size is 0, the function does no checks and returns PTR. */
|
||||||
|
static void
|
||||||
|
validate_user_pointer (const void *ptr, size_t size, bool check_write)
|
||||||
|
{
|
||||||
|
if (size == 0)
|
||||||
|
return;
|
||||||
|
/* ptr < ptr + size - 1, so sufficient to check that (ptr + size -1) is a
|
||||||
|
valid user virtual memory address. */
|
||||||
|
void *last = ptr + size - 1;
|
||||||
|
if (!is_user_vaddr (last))
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
ptr = pg_round_down (ptr);
|
||||||
|
while (ptr <= last)
|
||||||
|
{
|
||||||
|
int result;
|
||||||
|
/* Check read access to pointer. */
|
||||||
|
if ((result = get_user (ptr)) == -1)
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
/* Check write access to pointer (if required). */
|
||||||
|
if (check_write && !put_user (ptr, result))
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
ptr += PGSIZE;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Validates of a C-string starting at ptr is fully contained within valid
|
||||||
|
user virtual memory. thread_exit () if the memory is invalid. */
|
||||||
|
static void
|
||||||
|
validate_user_string (const char *ptr, bool check_write)
|
||||||
|
{
|
||||||
|
size_t offset = (uintptr_t) ptr % PGSIZE;
|
||||||
|
|
||||||
|
for (;;)
|
||||||
|
{
|
||||||
|
void *page = pg_round_down (ptr);
|
||||||
|
|
||||||
|
if (!is_user_vaddr (page))
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
if (!is_user_vaddr (ptr))
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
int result;
|
||||||
|
if ((result = get_user ((const uint8_t *)ptr)) == -1)
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
if (check_write && !put_user ((uint8_t *)ptr, result))
|
||||||
|
syscall_exit (EXIT_FAILURE);
|
||||||
|
|
||||||
|
while (offset < PGSIZE)
|
||||||
|
{
|
||||||
|
if (*ptr == '\0')
|
||||||
|
return; /* We reached the end of the string without issues. */
|
||||||
|
|
||||||
|
ptr++;
|
||||||
|
offset++;
|
||||||
|
}
|
||||||
|
|
||||||
|
offset = 0;
|
||||||
|
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* PROVIDED BY SPEC.
|
||||||
|
Reads a byte at user virtual address UADDR.
|
||||||
|
UADDR must be below PHYS_BASE.
|
||||||
|
Returns the byte value if successful, -1 if a segfault occurred. */
|
||||||
|
static int
|
||||||
|
get_user (const uint8_t *uaddr)
|
||||||
|
{
|
||||||
|
int result;
|
||||||
|
asm ("movl $1f, %0; movzbl %1, %0; 1:" : "=&a"(result) : "m"(*uaddr));
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* PROVIDED BY SPEC.
|
||||||
|
Writes BYTE to user address UDST.
|
||||||
|
UDST must be below PHYS_BASE.
|
||||||
|
Returns true if successful, false if a segfault occurred. */
|
||||||
|
static bool
|
||||||
|
put_user (uint8_t *udst, uint8_t byte)
|
||||||
|
{
|
||||||
|
int error_code;
|
||||||
|
asm ("movl $1f, %0; movb %b2, %1; 1:"
|
||||||
|
: "=&a"(error_code), "=m"(*udst)
|
||||||
|
: "q"(byte));
|
||||||
|
return error_code != -1;
|
||||||
|
}
|
||||||
@@ -1,6 +1,17 @@
|
|||||||
#ifndef USERPROG_SYSCALL_H
|
#ifndef USERPROG_SYSCALL_H
|
||||||
#define USERPROG_SYSCALL_H
|
#define USERPROG_SYSCALL_H
|
||||||
|
|
||||||
|
#include <hash.h>
|
||||||
|
#include "threads/synch.h"
|
||||||
|
|
||||||
|
typedef int pid_t;
|
||||||
|
|
||||||
|
struct lock filesys_lock;
|
||||||
|
|
||||||
void syscall_init (void);
|
void syscall_init (void);
|
||||||
|
|
||||||
|
unsigned fd_hash (const struct hash_elem *element, void *aux);
|
||||||
|
bool fd_less (const struct hash_elem *a, const struct hash_elem *b, void *aux);
|
||||||
|
void fd_cleanup (struct hash_elem *e, void *aux);
|
||||||
|
|
||||||
#endif /* userprog/syscall.h */
|
#endif /* userprog/syscall.h */
|
||||||
|
|||||||
256
src/vm/frame.c
Normal file
256
src/vm/frame.c
Normal file
@@ -0,0 +1,256 @@
|
|||||||
|
#include <debug.h>
|
||||||
|
#include <hash.h>
|
||||||
|
#include <list.h>
|
||||||
|
#include <string.h>
|
||||||
|
|
||||||
|
#include "frame.h"
|
||||||
|
#include "page.h"
|
||||||
|
#include "threads/malloc.h"
|
||||||
|
#include "threads/vaddr.h"
|
||||||
|
#include "userprog/pagedir.h"
|
||||||
|
#include "threads/synch.h"
|
||||||
|
#include "devices/swap.h"
|
||||||
|
|
||||||
|
/* Hash table that maps every active frame's kernel virtual address
|
||||||
|
to its corresponding 'frame_metadata'.*/
|
||||||
|
struct hash frame_table;
|
||||||
|
|
||||||
|
/* Linked list used to represent the circular queue in the 'clock'
|
||||||
|
algorithm for page eviction. Iterating from the element that is
|
||||||
|
currently pointed at by 'next_victim' yields an ordering of the entries
|
||||||
|
from oldest to newest (in terms of when they were added or checked
|
||||||
|
for having been referenced by a process). */
|
||||||
|
struct list lru_list;
|
||||||
|
|
||||||
|
/* The next element in lru_list to be considered for eviction (oldest added
|
||||||
|
or referenced page in the circular queue). If this page has has an
|
||||||
|
'accessed' bit of 0 when considering eviction, then it will be the next
|
||||||
|
victim. Otherwise, the next element in the queue is similarly considered. */
|
||||||
|
struct list_elem *next_victim = NULL;
|
||||||
|
|
||||||
|
/* Synchronisation variables. */
|
||||||
|
/* Protects access to 'lru_list'. */
|
||||||
|
struct lock lru_lock;
|
||||||
|
|
||||||
|
struct frame_metadata
|
||||||
|
{
|
||||||
|
void *frame; /* The kernel virtual address holding the frame. */
|
||||||
|
void *upage; /* The user virtual address pointing to the frame. */
|
||||||
|
struct thread *owner; /* Pointer to the thread that owns the frame. */
|
||||||
|
struct hash_elem hash_elem; /* Tracks the position of the frame metadata
|
||||||
|
within 'frame_table', whose key is the
|
||||||
|
kernel virtual address of the frame. */
|
||||||
|
struct list_elem list_elem; /* Tracks the position of the frame metadata
|
||||||
|
in either the 'active' or 'inactive' list,
|
||||||
|
so a victim can be chosen for eviction. */
|
||||||
|
};
|
||||||
|
|
||||||
|
hash_hash_func frame_metadata_hash;
|
||||||
|
hash_less_func frame_metadata_less;
|
||||||
|
|
||||||
|
static struct list_elem *lru_next (struct list_elem *e);
|
||||||
|
static struct list_elem *lru_prev (struct list_elem *e);
|
||||||
|
static struct frame_metadata *get_victim (void);
|
||||||
|
|
||||||
|
/* Initialize the frame system by initializing the frame (hash) table with
|
||||||
|
the frame_metadata hashing and comparison functions, as well as initializing
|
||||||
|
'lru_list' and its associated synchronisation primitives. */
|
||||||
|
void
|
||||||
|
frame_init (void)
|
||||||
|
{
|
||||||
|
hash_init (&frame_table, frame_metadata_hash, frame_metadata_less, NULL);
|
||||||
|
|
||||||
|
list_init (&lru_list);
|
||||||
|
lock_init (&lru_lock);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* TODO: Consider synchronisation more closely (i.e. just for hash
|
||||||
|
table). */
|
||||||
|
/* Attempt to allocate a frame for a user process, either by direct
|
||||||
|
allocation of a user page if there is sufficient RAM, or by
|
||||||
|
evicting a currently active page if memory allocated for user
|
||||||
|
processes is fulled and storing it in swap. If swap is full in
|
||||||
|
the former case, panic the kernel. */
|
||||||
|
void *
|
||||||
|
frame_alloc (enum palloc_flags flags, void *upage, struct thread *owner)
|
||||||
|
{
|
||||||
|
struct frame_metadata *frame_metadata;
|
||||||
|
flags |= PAL_USER;
|
||||||
|
|
||||||
|
lock_acquire (&lru_lock);
|
||||||
|
void *frame = palloc_get_page (flags);
|
||||||
|
|
||||||
|
/* If a frame couldn't be allocated we must be out of main memory. Thus,
|
||||||
|
obtain a victim page to replace with our page, and swap the victim
|
||||||
|
into disk. */
|
||||||
|
if (frame == NULL)
|
||||||
|
{
|
||||||
|
/* 1. Obtain victim. */
|
||||||
|
if (next_victim == NULL)
|
||||||
|
PANIC ("Couldn't allocate a single page to main memory!\n");
|
||||||
|
|
||||||
|
struct frame_metadata *victim = get_victim ();
|
||||||
|
ASSERT (victim != NULL); /* get_victim () should never return null. */
|
||||||
|
|
||||||
|
/* 2. Swap out victim into disk. */
|
||||||
|
size_t swap_slot = swap_out (victim->frame);
|
||||||
|
page_set_swap (victim->owner, victim->upage, swap_slot);
|
||||||
|
|
||||||
|
/* If zero flag is set, zero out the victim page. */
|
||||||
|
if (flags & PAL_ZERO)
|
||||||
|
memset (victim->frame, 0, PGSIZE);
|
||||||
|
|
||||||
|
/* 3. Indicate that the new frame's metadata will be stored
|
||||||
|
inside the same structure that stored the victim's metadata.
|
||||||
|
As both the new frame and the victim frame share the same kernel
|
||||||
|
virtual address, the hash map need not be updated, and neither
|
||||||
|
the list_elem value as both share the same lru_list position. */
|
||||||
|
frame_metadata = victim;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* If sufficient main memory allows the frame to be directly allocated,
|
||||||
|
we must update the frame table with a new entry, and grow lru_list. */
|
||||||
|
else
|
||||||
|
{
|
||||||
|
/* Must own lru_lock here, as otherwise there is a race condition
|
||||||
|
with next_victim either being NULL or uninitialized. */
|
||||||
|
frame_metadata = malloc (sizeof (struct frame_metadata));
|
||||||
|
frame_metadata->frame = frame;
|
||||||
|
|
||||||
|
/* Newly allocated frames are pushed to the back of the circular queue
|
||||||
|
represented by lru_list. Must explicitly handle the case where the
|
||||||
|
circular queue is empty (when next_victim == NULL). */
|
||||||
|
if (next_victim == NULL)
|
||||||
|
{
|
||||||
|
list_push_back (&lru_list, &frame_metadata->list_elem);
|
||||||
|
next_victim = &frame_metadata->list_elem;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
struct list_elem *lru_tail = lru_prev (next_victim);
|
||||||
|
list_insert (lru_tail, &frame_metadata->list_elem);
|
||||||
|
}
|
||||||
|
|
||||||
|
hash_insert (&frame_table, &frame_metadata->hash_elem);
|
||||||
|
}
|
||||||
|
|
||||||
|
frame_metadata->upage = upage;
|
||||||
|
frame_metadata->owner = owner;
|
||||||
|
lock_release (&lru_lock);
|
||||||
|
|
||||||
|
return frame_metadata->frame;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Attempt to deallocate a frame for a user process by removing it from the
|
||||||
|
frame table as well as lru_list, and freeing the underlying page
|
||||||
|
memory & metadata struct. Panics if the frame isn't active in memory. */
|
||||||
|
void
|
||||||
|
frame_free (void *frame)
|
||||||
|
{
|
||||||
|
struct frame_metadata key_metadata;
|
||||||
|
key_metadata.frame = frame;
|
||||||
|
|
||||||
|
struct hash_elem *e =
|
||||||
|
hash_delete (&frame_table, &key_metadata.hash_elem);
|
||||||
|
if (e == NULL) PANIC ("Attempted to free a frame at kernel address %p, "
|
||||||
|
"but this address is not allocated!\n", frame);
|
||||||
|
|
||||||
|
struct frame_metadata *frame_metadata =
|
||||||
|
hash_entry (e, struct frame_metadata, hash_elem);
|
||||||
|
|
||||||
|
lock_acquire (&lru_lock);
|
||||||
|
list_remove (&frame_metadata->list_elem);
|
||||||
|
|
||||||
|
/* If we're freeing the frame marked as the next victim, update
|
||||||
|
next_victim to either be the next least recently used page, or NULL
|
||||||
|
if no pages are loaded in main memory. */
|
||||||
|
if (&frame_metadata->list_elem == next_victim)
|
||||||
|
{
|
||||||
|
if (list_empty (&lru_list))
|
||||||
|
next_victim = NULL;
|
||||||
|
else
|
||||||
|
next_victim = lru_next (next_victim);
|
||||||
|
}
|
||||||
|
lock_release (&lru_lock);
|
||||||
|
|
||||||
|
free (frame_metadata);
|
||||||
|
palloc_free_page (frame);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* TODO: Account for page aliases when checking accessed bit. */
|
||||||
|
/* A pre-condition for calling this function is that the calling thread
|
||||||
|
owns lru_lock and that lru_list is non-empty. */
|
||||||
|
static struct frame_metadata *
|
||||||
|
get_victim (void)
|
||||||
|
{
|
||||||
|
struct list_elem *e = next_victim;
|
||||||
|
struct frame_metadata *frame_metadata;
|
||||||
|
uint32_t *pd;
|
||||||
|
void *upage;
|
||||||
|
for (;;)
|
||||||
|
{
|
||||||
|
frame_metadata = list_entry (e, struct frame_metadata, list_elem);
|
||||||
|
pd = frame_metadata->owner->pagedir;
|
||||||
|
upage = frame_metadata->upage;
|
||||||
|
e = lru_next (e);
|
||||||
|
|
||||||
|
if (!pagedir_is_accessed (pd, upage))
|
||||||
|
break;
|
||||||
|
|
||||||
|
pagedir_set_accessed (pd, upage, false);
|
||||||
|
}
|
||||||
|
|
||||||
|
next_victim = e;
|
||||||
|
return frame_metadata;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Hash function for frame metadata, used for storing entries in the
|
||||||
|
frame table. */
|
||||||
|
unsigned
|
||||||
|
frame_metadata_hash (const struct hash_elem *e, void *aux UNUSED)
|
||||||
|
{
|
||||||
|
struct frame_metadata *frame_metadata =
|
||||||
|
hash_entry (e, struct frame_metadata, hash_elem);
|
||||||
|
|
||||||
|
return hash_bytes (&frame_metadata->frame, sizeof (frame_metadata->frame));
|
||||||
|
}
|
||||||
|
|
||||||
|
/* 'less_func' comparison function for frame metadata, used for comparing
|
||||||
|
the keys of the frame table. Returns true iff the kernel virtual address
|
||||||
|
of the first frame is less than that of the second frame. */
|
||||||
|
bool
|
||||||
|
frame_metadata_less (const struct hash_elem *a_, const struct hash_elem *b_,
|
||||||
|
void *aux UNUSED)
|
||||||
|
{
|
||||||
|
struct frame_metadata *a =
|
||||||
|
hash_entry (a_, struct frame_metadata, hash_elem);
|
||||||
|
struct frame_metadata *b =
|
||||||
|
hash_entry (b_, struct frame_metadata, hash_elem);
|
||||||
|
|
||||||
|
return a->frame < b->frame;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Returns the next recently used element after the one provided, which
|
||||||
|
is achieved by iterating through lru_list like a circular queue
|
||||||
|
(wrapping around the list at the tail). */
|
||||||
|
static struct list_elem *
|
||||||
|
lru_next (struct list_elem *e)
|
||||||
|
{
|
||||||
|
if (!list_empty (&lru_list) && e == list_back (&lru_list))
|
||||||
|
return list_front (&lru_list);
|
||||||
|
|
||||||
|
return list_next (e);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Returns the previous recently used element after the one provided, which
|
||||||
|
is achieved by iterating through lru_list like a circular queue
|
||||||
|
(wrapping around the list at the head). */
|
||||||
|
static struct list_elem *
|
||||||
|
lru_prev (struct list_elem *e)
|
||||||
|
{
|
||||||
|
if (!list_empty (&lru_list) && e == list_front (&lru_list))
|
||||||
|
return list_back (&lru_list);
|
||||||
|
|
||||||
|
return list_prev (e);
|
||||||
|
}
|
||||||
|
|
||||||
11
src/vm/frame.h
Normal file
11
src/vm/frame.h
Normal file
@@ -0,0 +1,11 @@
|
|||||||
|
#ifndef VM_FRAME_H
|
||||||
|
#define VM_FRAME_H
|
||||||
|
|
||||||
|
#include "threads/thread.h"
|
||||||
|
#include "threads/palloc.h"
|
||||||
|
|
||||||
|
void frame_init (void);
|
||||||
|
void *frame_alloc (enum palloc_flags, void *, struct thread *);
|
||||||
|
void frame_free (void *frame);
|
||||||
|
|
||||||
|
#endif /* vm/frame.h */
|
||||||
20
src/vm/page.c
Normal file
20
src/vm/page.c
Normal file
@@ -0,0 +1,20 @@
|
|||||||
|
#include "page.h"
|
||||||
|
|
||||||
|
/* Updates the 'owner' thread's page table entry for virtual address 'upage'
|
||||||
|
to have a present bit of 0 and stores the specified swap slot value in the
|
||||||
|
entry for later retrieval from disk. */
|
||||||
|
void
|
||||||
|
page_set_swap (struct thread *owner, void *upage, size_t swap_slot)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Given that the page with user address 'upage' owned by 'owner' is flagged
|
||||||
|
to be in the swap disk via the owner's page table, returns its stored
|
||||||
|
swap slot. Otherwise panics the kernel. */
|
||||||
|
size_t
|
||||||
|
page_get_swap (struct thread *owner, void *upage)
|
||||||
|
{
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
9
src/vm/page.h
Normal file
9
src/vm/page.h
Normal file
@@ -0,0 +1,9 @@
|
|||||||
|
#ifndef VM_PAGE_H
|
||||||
|
#define VM_PAGE_H
|
||||||
|
|
||||||
|
#include "threads/thread.h"
|
||||||
|
|
||||||
|
void page_set_swap (struct thread *, void *, size_t);
|
||||||
|
size_t page_get_swap (struct thread *, void *);
|
||||||
|
|
||||||
|
#endif /* vm/frame.h */
|
||||||
50
src/vm/stackgrowth.c
Normal file
50
src/vm/stackgrowth.c
Normal file
@@ -0,0 +1,50 @@
|
|||||||
|
#include <stdio.h>
|
||||||
|
#include "stackgrowth.h"
|
||||||
|
#include "threads/palloc.h"
|
||||||
|
#include "threads/thread.h"
|
||||||
|
#include "threads/vaddr.h"
|
||||||
|
#include "userprog/pagedir.h"
|
||||||
|
|
||||||
|
#define MAX_STACK_ACCESS_DIST 32
|
||||||
|
|
||||||
|
static bool needs_new_page (const void *addr, const void *esp);
|
||||||
|
static bool grow_stack (const void *addr);
|
||||||
|
|
||||||
|
bool
|
||||||
|
try_alloc_new_page (const void *ptr, const void *esp)
|
||||||
|
{
|
||||||
|
return needs_new_page (ptr, esp) && grow_stack (ptr);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Validates a given address for being a stack query and not a generic erroneous
|
||||||
|
address
|
||||||
|
*/
|
||||||
|
static bool
|
||||||
|
needs_new_page (const void *addr, const void *esp)
|
||||||
|
{
|
||||||
|
return (is_user_vaddr (addr) &&
|
||||||
|
(uint32_t*)addr >= ((uint32_t*)esp - MAX_STACK_ACCESS_DIST) &&
|
||||||
|
((PHYS_BASE - pg_round_down (addr))
|
||||||
|
<= MAX_STACK_SIZE));
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Extends the stack by the necessary number of pages */
|
||||||
|
static bool
|
||||||
|
grow_stack (const void *addr)
|
||||||
|
{
|
||||||
|
struct thread *t = thread_current ();
|
||||||
|
void *last_page = pg_round_down (addr);
|
||||||
|
|
||||||
|
uint8_t *new_page = palloc_get_page (PAL_USER | PAL_ZERO);
|
||||||
|
if ( new_page == NULL)
|
||||||
|
return false;
|
||||||
|
|
||||||
|
bool added_page = pagedir_get_page (t->pagedir, last_page) == NULL
|
||||||
|
&& pagedir_set_page (t->pagedir, last_page, new_page, true);
|
||||||
|
|
||||||
|
if (!added_page) {
|
||||||
|
palloc_free_page (new_page);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
10
src/vm/stackgrowth.h
Normal file
10
src/vm/stackgrowth.h
Normal file
@@ -0,0 +1,10 @@
|
|||||||
|
#ifndef VM_GROWSTACK_H
|
||||||
|
#define VM_GROWSTACK_H
|
||||||
|
|
||||||
|
#include <stdio.h>
|
||||||
|
|
||||||
|
#define MAX_STACK_SIZE 8388608 // (8MB)
|
||||||
|
|
||||||
|
bool try_alloc_new_page (const void *ptr, const void *esp);
|
||||||
|
|
||||||
|
#endif /* vm/frame.h */
|
||||||
Reference in New Issue
Block a user