Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor System Calls and Process for Readability; Change FD to local counter and use it as hash #47

Merged
sb3923 merged 9 commits from task2/refactoring/saleh into master 2024-11-15 16:41:13 +00:00
Conversation 5 Commits 9 Files Changed 6
+130 -43
sb3923 commented 2024-11-15 15:59:12 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source
No description provided.
sb3923 commented 2024-11-15 15:59:12 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

requested review from @gk1623

requested review from @gk1623
sb3923 commented 2024-11-15 15:59:12 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

assigned to @sb3923

assigned to @sb3923
gk1623 commented 2024-11-15 16:13:13 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

I just realised fd_counter wasn't synchronised before, but now it doesn't matter since it's per-thread, right?

I just realised `fd_counter` wasn't synchronised before, but now it doesn't matter since it's per-thread, right?
gk1623 commented 2024-11-15 16:40:27 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

resolved all threads

resolved all threads
gk1623 commented 2024-11-15 16:41:13 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

mentioned in commit 222aeff90f

mentioned in commit 222aeff90f06ccf9ff023ce33aacc78470d1ce2a
gk1623 (Migrated from gitlab.doc.ic.ac.uk) merged commit 222aeff90f into master 2024-11-15 16:41:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cyclane (Gleb Koval)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/pintos_22#47