Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize stack initialization by not using malloc, and remove use of 'goto' (for code review safety) #41

Merged
td1223 merged 4 commits from stack-init-optimize into master 2024-11-14 16:06:23 +00:00
Conversation 5 Commits 4 Files Changed 1 +33 -38
td1223 commented 2024-11-14 15:25:03 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

Refactor process_execute to pass process start data as a local reference rather than perform memory allocation on the heap

Refactor process_execute to pass process start data as a local reference rather than perform memory allocation on the heap
td1223 commented 2024-11-14 15:25:03 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

assigned to @gk1623

assigned to @gk1623
td1223 commented 2024-11-14 15:54:49 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • 3a46e0f7 - Update user proc stack initialization comments to be more helpful

Compare with previous version

added 1 commit <ul><li>3a46e0f7 - Update user proc stack initialization comments to be more helpful</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/41/diffs?diff_id=139166&start_sha=882185145944e90e5a637c2c4023850208e80a8a)
gk1623 commented 2024-11-14 15:57:04 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

approved this merge request

approved this merge request
td1223 (Migrated from gitlab.doc.ic.ac.uk) closed this pull request 2024-11-14 16:02:17 +00:00
td1223 (Migrated from gitlab.doc.ic.ac.uk) reopened this pull request 2024-11-14 16:03:27 +00:00
td1223 (Migrated from gitlab.doc.ic.ac.uk) closed this pull request 2024-11-14 16:03:34 +00:00
td1223 (Migrated from gitlab.doc.ic.ac.uk) reopened this pull request 2024-11-14 16:06:15 +00:00
td1223 commented 2024-11-14 16:06:23 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

mentioned in commit bbe41e178d

mentioned in commit bbe41e178dcb74b06334cb1719020b26f87e0de7
td1223 (Migrated from gitlab.doc.ic.ac.uk) merged commit bbe41e178d into master 2024-11-14 16:06:23 +00:00
gk1623 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:43:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gk1623
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cyclane
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/pintos_22#41
No description provided.
Delete Branch "stack-init-optimize"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?