Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Re-sort ready_list when priorities update + PRI_UPDATE_FREQ #17

Merged
gk1623 merged 1 commits from gleb/fix-bsd-ready-list-order into master 2024-10-25 08:32:09 +00:00
Conversation 4 Commits 1 Files Changed 1
+5 -1
gk1623 commented 2024-10-25 08:15:24 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source
  • We need to re-sort ready_list after updating all the priorities. Expensive, but no way around it I think.
  • PRI_UPDATE_FREQ is a separate value from TIME_SLICE, they just
    happen to be set the same.
- We need to re-sort `ready_list` after updating all the priorities. Expensive, but no way around it I think. - PRI_UPDATE_FREQ is a separate value from TIME_SLICE, they just happen to be set the same.
sb3923 commented 2024-10-25 08:31:05 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

approved this merge request

approved this merge request
sb3923 commented 2024-10-25 08:31:57 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

LGTM!
We had a function to resort the ready list that was then removed as it turned out it was not necessary in our case.
It is also a good bet to resort even if it was unnecessary as O(n log n) will be better than repeated O(n) for large enough number of n.

LGTM! We had a function to resort the ready list that was then removed as it turned out it was not necessary in our case. It is also a good bet to resort even if it was unnecessary as O(n log n) will be better than repeated O(n) for large enough number of n.
sb3923 commented 2024-10-25 08:32:09 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

mentioned in commit af31968e67

mentioned in commit af31968e6740fcc53e07be4bb105e8bd8f1c9685
sb3923 (Migrated from gitlab.doc.ic.ac.uk) merged commit af31968e67 into master 2024-10-25 08:32:09 +00:00
sb3923 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:43:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sb3923
Labels
No items
No labels
Milestone
No items
No Milestone Task 1: Scheduling
Projects
Clear projects
No projects
Assignees
Clear assignees
cyclane (Gleb Koval)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/pintos_22#17