Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Implement non-busy timer_sleep (task 0) #1

Merged
gk1623 merged 1 commits from gleb/non-busy-sleep into master 2024-10-14 18:29:17 +00:00
Conversation 10 Commits 1 Files Changed 1 +49 -2
gk1623 commented 2024-10-10 10:30:01 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

As per spec, we need to add an implementation of task 0 to the group repo.

Note: opting for separate struct, instead of modifying existing struct thread because:

  1. Better code separation.
  2. More memory efficient.
    • The new structs themselves are slightly bigger.
    • But the alternative makes ALL struct thread slightly bigger, which there are many more of than sleeping threads.
As per spec, we need to add an implementation of task 0 to the group repo. **Note:** opting for separate struct, instead of modifying existing `struct thread` because: 1. Better code separation. 2. More memory efficient. - The new structs themselves are slightly bigger. - But the alternative makes ALL `struct thread` slightly bigger, which there are many more of than sleeping threads.
gk1623 commented 2024-10-10 10:48:14 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • f318e013 - Implement non-busy timer_sleep (task 0)

Compare with previous version

added 1 commit <ul><li>f318e013 - Implement non-busy timer_sleep (task 0)</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135524&start_sha=4deb887f1223343d077654aee029bb315431024e)
gk1623 commented 2024-10-10 14:33:42 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • ec71218f - Do not use malloc for timer_sleep

Compare with previous version

added 1 commit <ul><li>ec71218f - Do not use malloc for timer_sleep</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135557&start_sha=f318e0133ae4476d9e76e497cfa5228452c6cc55)
gk1623 commented 2024-10-10 14:35:07 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • 7061b21b - Implement non-busy timer_sleep (task 0)

Compare with previous version

added 1 commit <ul><li>7061b21b - Implement non-busy timer_sleep (task 0)</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135559&start_sha=ec71218f088899d8830cc9979a66ee188856b1e8)
gk1623 commented 2024-10-10 14:53:52 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

changed the description

changed the description
gk1623 commented 2024-10-11 14:11:40 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • ea27e21d - Implement non-busy timer_sleep (task 0)

Compare with previous version

added 1 commit <ul><li>ea27e21d - Implement non-busy timer_sleep (task 0)</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135694&start_sha=7061b21b7230def686b4b5bd3b21a8288fea8e44)
gk1623 commented 2024-10-11 14:13:46 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • f1f705df - Implement non-busy timer_sleep (task 0)

Compare with previous version

added 1 commit <ul><li>f1f705df - Implement non-busy timer_sleep (task 0)</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135696&start_sha=ea27e21d52eeeaefb7a06d6340115fc0e118989e)
gk1623 commented 2024-10-14 18:22:03 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • f5d130f8 - Implement non-busy timer_sleep (task 0)

Compare with previous version

added 1 commit <ul><li>f5d130f8 - Implement non-busy timer_sleep (task 0)</li></ul> [Compare with previous version](/lab2425_autumn/pintos_22/-/merge_requests/1/diffs?diff_id=135865&start_sha=f1f705df3b364da6efee2a860313304fd567ccc1)
ed1223 commented 2024-10-14 18:29:02 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

approved this merge request

approved this merge request
ed1223 commented 2024-10-14 18:29:17 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

mentioned in commit 1be1350941

mentioned in commit 1be13509419139c7ab54502a4e41a810b42b4f96
ed1223 (Migrated from gitlab.doc.ic.ac.uk) merged commit 1be1350941 into master 2024-10-14 18:29:17 +00:00
ed1223 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:43:34 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ed1223
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cyclane
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/pintos_22#1
No description provided.
Delete Branch "gleb/non-busy-sleep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?