Imperial-MEng/drp-48
1
0
Fork 0
Code Issues 17 Pull Requests Actions Packages Projects Releases Wiki Activity

Compulsory tags #37

Merged
al4423 merged 4 commits from compulsory-tags into master 2025-06-09 18:30:57 +00:00
Conversation 11 Commits 4 Files Changed 9
+210 -27
al4423 commented 2025-06-09 16:27:24 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

Compulsory tags for noise level, power outlets, and wifi. Contributes to #21

Compulsory tags for noise level, power outlets, and wifi. Contributes to #21
al4423 commented 2025-06-09 18:17:45 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

added 1 commit

  • 61915cd6 - refactor: used a record for tag colouring

Compare with previous version

added 1 commit <ul><li>61915cd6 - refactor: used a record for tag colouring</li></ul> [Compare with previous version](/gk1623/drp-48/-/merge_requests/7/diffs?diff_id=168750&start_sha=3cec4981927440a8aa93d8c79c58567249e60881)
gk1623 commented 2025-06-09 18:23:13 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source
    import { Table } from "$lib";

    interface Props {
        space: Table<"study_spaces">;
    }

    const { space }: Props = $props();
```suggestion:-0+0 import { Table } from "$lib"; interface Props { space: Table<"study_spaces">; } const { space }: Props = $props(); ```
gk1623 commented 2025-06-09 18:23:13 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

Pls keep imports at the top.

Pls keep imports at the top.
gk1623 commented 2025-06-09 18:23:14 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

left review comments

left review comments
al4423 commented 2025-06-09 18:27:34 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/gk1623/drp-48/-/merge_requests/7/diffs?diff_id=168752&start_sha=61915cd6a6d4828d629266493d1862bff65ee986#b8b774c32f5258280d813d6a1a75c6aa43bf1754_2_2)
al4423 commented 2025-06-09 18:27:34 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/gk1623/drp-48/-/merge_requests/7/diffs?diff_id=168752&start_sha=61915cd6a6d4828d629266493d1862bff65ee986#26f75865975c98145c317faa32743e60d80b3785_12_13)
al4423 commented 2025-06-09 18:27:34 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

added 1 commit

  • 6a9f5ca2 - refactor: Fixed minor typing issue with space

Compare with previous version

added 1 commit <ul><li>6a9f5ca2 - refactor: Fixed minor typing issue with space</li></ul> [Compare with previous version](/gk1623/drp-48/-/merge_requests/7/diffs?diff_id=168752&start_sha=61915cd6a6d4828d629266493d1862bff65ee986)
al4423 commented 2025-06-09 18:28:14 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

resolved all threads

resolved all threads
gk1623 commented 2025-06-09 18:28:57 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

approved this merge request

approved this merge request
al4423 (Migrated from gitlab.doc.ic.ac.uk) scheduled this pull request to auto merge when all checks succeed 2025-06-09 18:29:15 +00:00
al4423 commented 2025-06-09 18:30:56 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

mentioned in commit b727665238

mentioned in commit b727665238ef2059776344cd436ad8386d5f364e
al4423 (Migrated from gitlab.doc.ic.ac.uk) merged commit b727665238 into master 2025-06-09 18:30:57 +00:00
gk1623 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:44:03 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gk1623
Labels
Clear labels
Cancelled
In-progress
Review
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cyclane (Gleb Koval)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/drp-48#37