Imperial-MEng/WACC_37
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: implemented labelAndExplain(), combining label and explain, and... #9

Merged
gc1523 merged 18 commits from error-messages into master 2025-02-06 20:30:26 +00:00
Conversation 5 Commits 18 Files Changed 7
+567 -133
gc1523 commented 2025-02-06 17:50:43 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

refactor: implemented labelAndExplain(), combining label and explain, and provided explanations for expr

Co-authored-by: gc1523

refactor: implemented labelAndExplain(), combining label and explain, and provided explanations for expr Co-authored-by: gc1523
gc1523 commented 2025-02-06 17:55:39 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

added 11 commits

  • 570ee36d...2fb520d8 - 10 commits from branch master
  • ddd138b8 - Merge branch 'master' into 'error-messages'

Compare with previous version

added 11 commits <ul><li>570ee36d...2fb520d8 - 10 commits from branch <code>master</code></li><li>ddd138b8 - Merge branch &#39;master&#39; into &#39;error-messages&#39;</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/9/diffs?diff_id=147694&start_sha=570ee36d8a722b61c00bad55d4484fe38610b49e)
gc1523 (Migrated from gitlab.doc.ic.ac.uk) closed this pull request 2025-02-06 18:00:54 +00:00
gc1523 (Migrated from gitlab.doc.ic.ac.uk) reopened this pull request 2025-02-06 18:03:09 +00:00
al4423 commented 2025-02-06 19:56:23 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

added 12 commits

  • ddd138b8...19880321 - 2 earlier commits
  • 8b64f2e3 - fix: removed redundant labelling in ast
  • bd779931 - refactor: style fixes in parser
  • 1486296b - refactor: add position tracking to AST, UnaryOp, BinaryOp
  • 6d1c0b7a - fix: make parser use only parsley parser bridge apply
  • e9ed1977 - fix: remove unused applyCon from AST
  • 3fbb9032 - feat: renamer maybe maybe maybe maybe
  • 30cf42ee - fix: separate variable and function in scope
  • ae9625b5 - fix: use apply() instead of get() for Maps
  • 74f62ea9 - fix: fix merge breaks, add function names to scope before renaming bodies
  • 0e2d1af8 - refactor: add comments to renamer

Compare with previous version

added 12 commits <ul><li>ddd138b8...19880321 - 2 earlier commits</li><li>8b64f2e3 - fix: removed redundant labelling in ast</li><li>bd779931 - refactor: style fixes in parser</li><li>1486296b - refactor: add position tracking to AST, UnaryOp, BinaryOp</li><li>6d1c0b7a - fix: make parser use only parsley parser bridge apply</li><li>e9ed1977 - fix: remove unused applyCon from AST</li><li>3fbb9032 - feat: renamer maybe maybe maybe maybe</li><li>30cf42ee - fix: separate variable and function in scope</li><li>ae9625b5 - fix: use apply() instead of get() for Maps</li><li>74f62ea9 - fix: fix merge breaks, add function names to scope before renaming bodies</li><li>0e2d1af8 - refactor: add comments to renamer</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/9/diffs?diff_id=147848&start_sha=ddd138b88aae9123943a6631b83259ede21c5db9)
gc1523 commented 2025-02-06 20:28:07 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

approved this merge request

approved this merge request
gk1623 commented 2025-02-06 20:30:21 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
Copy Source

mentioned in commit 4dc07c249a

mentioned in commit 4dc07c249ad55f567108a40e9a57ede02f81cc68
gk1623 (Migrated from gitlab.doc.ic.ac.uk) merged commit 4dc07c249a into master 2025-02-06 20:30:26 +00:00
gc1523 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:43:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gc1523
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cyclane (Gleb Koval)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/WACC_37#9