Imperial-MEng/WACC_37
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: merge comments and extracting constants & renaming refactors #36

Merged
gk1623 merged 9 commits from comments-and-refactors into master 2025-02-28 15:32:47 +00:00
Conversation 3 Commits 9 Files Changed 3 +237 -205
gk1623 commented 2025-02-28 15:06:31 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
No description provided.
gk1623 commented 2025-02-28 15:22:24 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 5 commits

  • c3f2ce8b...cf72c525 - 4 commits from branch master
  • 720d9320 - Merge branch 'master' into comments-and-refactors

Compare with previous version

added 5 commits <ul><li>c3f2ce8b...cf72c525 - 4 commits from branch <code>master</code></li><li>720d9320 - Merge branch &#39;master&#39; into comments-and-refactors</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/36/diffs?diff_id=156081&start_sha=c3f2ce8b197de1bf16e32e01be63f3e51f488261)
gk1623 commented 2025-02-28 15:30:05 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • 82997a5a - docs: clarify evalExprOntoStack sanity check, explanation comments for generateCall

Compare with previous version

added 1 commit <ul><li>82997a5a - docs: clarify evalExprOntoStack sanity check, explanation comments for generateCall</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/36/diffs?diff_id=156094&start_sha=720d9320e21a41f75104ebbe0dac275d281b02fc)
gk1623 (Migrated from gitlab.doc.ic.ac.uk) scheduled this pull request to auto merge when all checks succeed 2025-02-28 15:30:11 +00:00
gk1623 commented 2025-02-28 15:32:47 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

mentioned in commit 61643a49eb

mentioned in commit 61643a49ebc734215675369ddd619b118230b49e
gk1623 (Migrated from gitlab.doc.ic.ac.uk) merged commit 61643a49eb into master 2025-02-28 15:32:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cyclane
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/WACC_37#36
No description provided.
Delete Branch "comments-and-refactors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?