Imperial-MEng/WACC_37
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: exit with exit code, read space-delimited tokens #30

Closed
gk1623 wants to merge 0 commits from labts-fixes into master
pull from: labts-fixes
merge into: Imperial-MEng:master
Conversation 3 Commits - Files Changed - +15 -23
gk1623 commented 2025-02-27 19:59:39 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link
  • Accidentally removed System.exit call, add it back in
  • Read space delimited tokens by using scanf formats " %c" and " %d" (instead of without space like before)
    • I don't actually know how this works, but reference compiler does it and it seems to have fixed the tests soooooo
  • Fix runtime error test checks by replacing everything after fatal error: with #runtime_error#
- Accidentally removed `System.exit` call, add it back in - Read space delimited tokens by using scanf formats `" %c"` and `" %d"` (instead of without space like before) - I don't actually know how this works, but reference compiler does it and it seems to have fixed the tests soooooo - Fix runtime error test checks by replacing everything after `fatal error:` with `#runtime_error#`
gk1623 commented 2025-02-27 20:00:13 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

Compare with previous version

added 1 commit <ul><li>c31dd9de - style: scala format</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/30/diffs?diff_id=155310&start_sha=edce23615857a8f210cac64bf42ebd9a8f748327)
gk1623 commented 2025-02-27 20:01:14 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

changed the description

changed the description
gk1623 commented 2025-02-27 20:04:12 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

changed the description

changed the description
gc1523 (Migrated from gitlab.doc.ic.ac.uk) closed this pull request 2025-02-27 21:58:04 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cyclane
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/WACC_37#30
No description provided.
Delete Branch "labts-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?