Imperial-MEng/WACC_37
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Local Mutable Chains #27

Merged
jt2622 merged 5 commits from optimisations into asm-gen 2025-02-25 21:13:48 +00:00
Conversation 8 Commits 5 Files Changed 1 +304 -323
jt2622 commented 2025-02-25 20:00:45 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

Local Mutable Chains used instead of Lists - better efficiency and code clarity

Local Mutable Chains used instead of Lists - better efficiency and code clarity
jt2622 commented 2025-02-25 20:00:45 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

requested review from @gk1623

requested review from @gk1623
jt2622 commented 2025-02-25 20:00:45 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

assigned to @jt2622

assigned to @jt2622
gk1623 commented 2025-02-25 20:39:32 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 1 commit

  • 22591bc7 - style: scala format

Compare with previous version

added 1 commit <ul><li>22591bc7 - style: scala format</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/27/diffs?diff_id=153919&start_sha=88ca199c7fb3c361b6e2e5e89372665bae19b3b1)
gk1623 commented 2025-02-25 20:50:54 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 2 commits

  • 3e1ff7e2 - Merge branch 'asm-gen' into optimisations
  • 23ba6d6c - fix: add `+` (not `+=`) to Chain

Compare with previous version

added 2 commits <ul><li>3e1ff7e2 - Merge branch &#39;asm-gen&#39; into optimisations</li><li>23ba6d6c - fix: add `+` (not `+=`) to Chain</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/27/diffs?diff_id=153920&start_sha=22591bc7159c5be432a47f9d1f0a5dc2caa49c78)
gk1623 commented 2025-02-25 21:06:10 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

added 11 commits

  • 88ca199c...7fd92b42 - 6 commits from branch asm-gen
  • 7953790f - feat: used Chains instead of Lists
  • edbc03ee - feat: used local mutable Chains. Also implemented new LabelGenerator
  • bd0eb76b - fix: alignment issue with stack in read
  • ebc65af9 - feat: extension method concatAll defined on Chain implemented
  • 11c48343 - fix: generate strDirs after prog, change `+=` to `+`

Compare with previous version

added 11 commits <ul><li>88ca199c...7fd92b42 - 6 commits from branch <code>asm-gen</code></li><li>7953790f - feat: used Chains instead of Lists</li><li>edbc03ee - feat: used local mutable Chains. Also implemented new LabelGenerator</li><li>bd0eb76b - fix: alignment issue with stack in read</li><li>ebc65af9 - feat: extension method concatAll defined on Chain implemented</li><li>11c48343 - fix: generate strDirs after prog, change `+=` to `+`</li></ul> [Compare with previous version](/lab2425_spring/WACC_37/-/merge_requests/27/diffs?diff_id=153929&start_sha=88ca199c7fb3c361b6e2e5e89372665bae19b3b1)
gk1623 commented 2025-02-25 21:13:42 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

approved this merge request

approved this merge request
gk1623 commented 2025-02-25 21:13:47 +00:00 (Migrated from gitlab.doc.ic.ac.uk)
Copy Link

mentioned in commit 70e023f27a

mentioned in commit 70e023f27a69fc8707f23e5c0efdaacea8546b7f
gk1623 (Migrated from gitlab.doc.ic.ac.uk) merged commit 70e023f27a into asm-gen 2025-02-25 21:13:48 +00:00
gk1623 (Migrated from gitlab.doc.ic.ac.uk) approved these changes 2025-10-16 16:43:49 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
gk1623
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
cyclane
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Imperial-MEng/WACC_37#27
No description provided.
Delete Branch "optimisations"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?