Branch support #7

2024-01-10T12:15:20Z

cyclane commented

2024-01-10 12:15:20 +00:00

Closes #6.

Implements branch support by only extending the existing functionality. Note that the existing functionality DOES NOT implement a parent pointer for commits, and as a result branches are also implemented differently to how git implements them.

git branches are simply a named pointer to a commit object (which then has a pointer to its parent commit), here branches store the entire sequence of pointers to commit objects.

Why different to git?

I made a mistake in the initial implementation by using a TreeSet instead of manually implementing a tree for commits. This allowed the ability to insert commits in-between other commits, which isn't normally possible in git without rebasing which changes commits' hashes.

The specification for this feature stated:

All functionality that is implemented already should be preserved.

And so since I cannot remove this functionality any more, I have to build on top of it.

Closes #6. Implements branch support by _only extending_ the existing functionality. Note that the existing functionality DOES NOT implement a `parent` pointer for commits, and as a result branches are also implemented differently to how git implements them. git branches are simply a named pointer to a commit object (which then has a pointer to its parent commit), here branches store the entire sequence of pointers to commit objects. ### Why different to git? I made a mistake in the initial implementation by using a `TreeSet` instead of manually implementing a tree for commits. This allowed the ability to insert commits in-between other commits, which isn't normally possible in `git` _without rebasing which changes commits' hashes_. The specification for this feature stated: > All functionality that is implemented already should be preserved. And so since I cannot remove this functionality any more, I have to build on top of it.

cyclane added 1 commit 2024-01-10 12:15:21 +00:00

Implement branches + tests

Test Workflow / Lint and test library (pull_request) Successful in 1m55s

Details

8352c3c9be

cyclane merged commit dbc1bdd105 into main

2024-01-10 12:21:26 +00:00

cyclane deleted branch branch-support

2024-01-10 12:21:26 +00:00

cyclane referenced this issue from a commit

2024-01-10 12:21:27 +00:00

Branch support (#7)

This repo is archived. You cannot comment on pull requests.

1 Participants

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cyclane/teamcity-gitea-test-task#7