cyclane/teamcity-build-step-extension-test-task
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 2 Activity

Improve tests & validate FSEntry names #4

Merged
cyclane merged 6 commits from improve-tests into main 2024-01-07 16:09:24 +00:00
Conversation 0 Commits 6 Files Changed 4
+200 -32
cyclane commented 2024-01-07 15:05:23 +00:00
Owner
Copy Link
Copy Source

Contributes to #2 .

  • Add some additional tests to existing functionality.
  • Cleanup code to use more of kotlin.io.* instead of java.nio.*.
  • Validate FSEntry names on object construction (and tests).
  • Validate folders do not contain entries with duplicate names on FSCreator.create() (and tests).
Contributes to #2 . - Add some additional tests to existing functionality. - Cleanup code to use more of `kotlin.io.*` instead of `java.nio.*`. - Validate FSEntry names on object construction (and tests). - Validate folders do not contain entries with duplicate names on `FSCreator.create()` (and tests).
cyclane added 2 commits 2024-01-07 15:05:24 +00:00
Test create file & cleanup 726980a669
Verify FSEntry name
Test Workflow / Lint and test library (pull_request) Successful in 1m42s
Details
e7dd3fa073
cyclane added a new dependency 2024-01-07 15:05:51 +00:00
#2 Feedback
cyclane added 1 commit 2024-01-07 15:34:03 +00:00
Do not allow folder contents to have duplicate names.
Test Workflow / Lint and test library (pull_request) Failing after 1m10s
Details
b0f3640eb6
cyclane added 1 commit 2024-01-07 15:59:16 +00:00
FSEntry name validation and duplicate names in folder tests
Test Workflow / Lint and test library (pull_request) Failing after 1m13s
Details
8500f69479
cyclane added 1 commit 2024-01-07 16:01:59 +00:00
Use Kotlin Path instead of Java Path
Test Workflow / Lint and test library (pull_request) Failing after 1m13s
Details
9169206ed8
cyclane added 1 commit 2024-01-07 16:04:39 +00:00
Format Kotlin
Test Workflow / Lint and test library (pull_request) Successful in 1m33s
Details
afcc71e516
cyclane marked the pull request as ready for review 2024-01-07 16:04:41 +00:00
cyclane scheduled this pull request to auto merge when all checks succeed 2024-01-07 16:04:59 +00:00
cyclane merged commit 8426dff044 into main 2024-01-07 16:09:24 +00:00
cyclane deleted branch improve-tests 2024-01-07 16:09:24 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
cyclane (Gleb Koval)
No Assignees
1 Participants
Due Date
No due date set.
Blocks
#2 Feedback
cyclane/teamcity-build-step-extension-test-task
Reference: cyclane/teamcity-build-step-extension-test-task#4