fix: synchronise threads' SPTs with locks #66

Merged
gk1623 merged 1 commits from vm/pagedir-spt-synch into master 2024-12-06 17:44:34 +00:00
4 changed files with 13 additions and 1 deletions

View File

@@ -736,6 +736,8 @@ init_thread (struct thread *t, const char *name, int nice, int priority,
t->recent_cpu = recent_cpu;
t->priority = t->base_priority;
lock_init (&t->pages_lock);
old_level = intr_disable ();
list_push_back (&all_list, &t->allelem);
intr_set_level (old_level);

View File

@@ -136,6 +136,7 @@ struct thread
struct list_elem elem; /* List element. */
struct hash pages; /* Table of open user pages. */
struct lock pages_lock; /* Lock for the supplementary page table. */
/* Memory mapped files for user virtual memory. */
struct hash mmap_files; /* List of memory mapped files. */

View File

@@ -371,7 +371,9 @@ process_exit (void)
hash_destroy (&cur->open_files, fd_cleanup);
/* Clean up the thread's supplemental page table. */
lock_acquire (&cur->pages_lock);
hash_destroy (&cur->pages, page_cleanup);
lock_release (&cur->pages_lock);
/* Close the executable file, implicitly allowing it to be written to. */
if (cur->exec_file != NULL)

View File

@@ -90,6 +90,7 @@ page_insert_swapped (void *upage, void *kpage, struct list *owners)
/* 1. Initialize swapped page entry. */
struct page_entry *page = page_get (owner, upage);
lock_acquire (&owner->pages_lock);
if (page == NULL)
{
page = malloc (sizeof (struct page_entry));
@@ -113,6 +114,7 @@ page_insert_swapped (void *upage, void *kpage, struct list *owners)
page_set_swap (owner, pte, swap_slot);
lock_release (&page->lock);
lock_release (&owner->pages_lock);
}
if (exec_file != NULL)
{
@@ -155,7 +157,10 @@ page_insert_file (struct file *file, off_t ofs, void *upage,
page->writable = writable;
lock_init (&page->lock);
hash_insert (&thread_current ()->pages, &page->elem);
struct thread *t = thread_current ();
lock_acquire (&t->pages_lock);
hash_insert (&t->pages, &page->elem);
lock_release (&t->pages_lock);
return page;
}
@@ -167,8 +172,10 @@ page_get (struct thread *thread, void *upage)
struct page_entry fake_page_entry;
fake_page_entry.upage = upage;
lock_acquire (&thread->pages_lock);
struct hash_elem *e
= hash_find (&thread->pages, &fake_page_entry.elem);
lock_release (&thread->pages_lock);
if (e == NULL)
return NULL;