Themis Demetriades
|
5e2e7199f2
|
Fix memory leak in start_process
|
2024-11-14 21:03:55 +00:00 |
|
Demetriades, Themis
|
bbe41e178d
|
Merge branch 'stack-init-optimize' into 'master'
Optimize stack initialization by not using malloc, and remove use of 'goto' (for code review safety)
See merge request lab2425_autumn/pintos_22!41
|
2024-11-14 16:06:22 +00:00 |
|
Themis Demetriades
|
e4036c715f
|
Refactor start_process to hold file system lock for less time
|
2024-11-14 16:05:15 +00:00 |
|
Themis Demetriades
|
3a46e0f73a
|
Update user proc stack initialization comments to be more helpful
|
2024-11-14 15:54:34 +00:00 |
|
Themis Demetriades
|
8821851459
|
Refactor process_execute to remove use of 'goto'
|
2024-11-14 14:42:26 +00:00 |
|
Themis Demetriades
|
1a2ff35231
|
Refactor process_execute to pass process start data as a local reference rather than perform memory allocation on the heap
|
2024-11-14 14:32:48 +00:00 |
|
Saleh Bubshait
|
79b3b8fda7
|
Merge branch 'userprog-oom' into 'master'
Fix multi-oom
See merge request lab2425_autumn/pintos_22!39
|
2024-11-13 22:09:11 +00:00 |
|
|
|
f5e498e0a9
|
explicit thread_exit () when process_start () fails
|
2024-11-13 21:58:41 +00:00 |
|
|
|
d02b956221
|
Merge branch 'system-calls' into 'userprog-oom'
Add Fixes to Memory Leaks, Memory Access Validation, Synchronised Processes and Refactoring
See merge request lab2425_autumn/pintos_22!38
|
2024-11-13 19:20:19 +00:00 |
|
Saleh Bubshait
|
927c376d02
|
Merge branch 'task2/system-calls/saleh' into 'system-calls'
Fix Memory Leaks, Synchronisation in Processes, and Refactoring
See merge request lab2425_autumn/pintos_22!37
|
2024-11-13 18:51:51 +00:00 |
|
sBubshait
|
fa2fb4a711
|
Refactor system call comments for accuracy and grammar
|
2024-11-13 18:48:23 +00:00 |
|
sBubshait
|
31ea215805
|
Refactor validate_user_string to remove unnecessary variable to track length of str
|
2024-11-13 18:30:24 +00:00 |
|
|
|
e7cb16b301
|
Fix child_results loop accessing next after free()
|
2024-11-13 18:29:05 +00:00 |
|
sBubshait
|
9549ca28e5
|
Refactor syscall: Use EXIT_FAILURE instead of magic numbers & close files on failure
|
2024-11-13 18:18:41 +00:00 |
|
sBubshait
|
b1c5819469
|
Avoid masking the struct syscall_arguments using typedef for consistency
|
2024-11-13 18:06:51 +00:00 |
|
sBubshait
|
287130ca7b
|
Update syscall.c to use syscall_exit on failure instead of calling thread_exit directly
|
2024-11-13 18:02:08 +00:00 |
|
sBubshait
|
4f586bb4da
|
Fix Bug: Free all entries in the fd hashtable when the process exits, w/ E
|
2024-11-13 17:42:25 +00:00 |
|
sBubshait
|
d890c2353e
|
Add constant MAX_SYSCALL_ARGS to avoid magic numbers [Gleb]
|
2024-11-13 17:16:15 +00:00 |
|
sBubshait
|
eb4f23c290
|
Add validate_user_string helper function to validate that a string is fully conatined within user vm
|
2024-11-13 17:11:37 +00:00 |
|
sBubshait
|
26de38cdba
|
Update validate_user_pointer to check if the memory block is mapped into a physical address
|
2024-11-13 16:39:45 +00:00 |
|
sBubshait
|
6e59e8c9f3
|
Update validate_user_pointer to be a void function
|
2024-11-13 16:22:16 +00:00 |
|
sBubshait
|
30e49846b5
|
Add more tests for system calls to deal with bad buffers given to read and write
|
2024-11-13 16:21:12 +00:00 |
|
|
|
005791edd2
|
Synchronise process_execute return with child process load
|
2024-11-13 11:05:09 +00:00 |
|
|
|
8bcd0a467c
|
Tidy up a69b9c808e
|
2024-11-12 21:35:41 +00:00 |
|
|
|
dd979f34c8
|
Fix syn-read, syn-write, and always free elements from donors_list
|
2024-11-12 21:30:23 +00:00 |
|
|
|
ca9d23edf9
|
Always release filesys_lock when checking if file is valid in process_execute
|
2024-11-12 20:07:51 +00:00 |
|
Themis Demetriades
|
d878dbc132
|
Fix bug in userprog-merge where file writes were denied in the wrong thread
|
2024-11-12 16:22:32 +00:00 |
|
Themis Demetriades
|
b0400693ae
|
Update process_execute to acquire lock when checking if file exists
|
2024-11-12 16:12:24 +00:00 |
|
Themis Demetriades
|
3418425f20
|
Don't acquire filesys lock when calling exec
|
2024-11-12 16:08:27 +00:00 |
|
|
|
59e7a64f8e
|
Only check user pages rather than all bytes in-between, for known-size pointers
|
2024-11-12 15:48:22 +00:00 |
|
|
|
cf4bf90cbb
|
Implement user pointer checking for C strings
|
2024-11-12 15:34:45 +00:00 |
|
|
|
9a6abab95e
|
Check access to user memory using page fault method (via get_user and put_user).
|
2024-11-12 15:00:16 +00:00 |
|
|
|
44f6a85163
|
Add get_user and put_user provided by spec.
|
2024-11-12 14:50:53 +00:00 |
|
|
|
83e044cf68
|
Let kernel handle its own page faults
|
2024-11-12 14:50:53 +00:00 |
|
Themis Demetriades
|
a69b9c808e
|
Update start_process to acquire filesys lock when loading user process file
|
2024-11-12 14:21:33 +00:00 |
|
Demetriades, Themis
|
7d9900c6d8
|
Merge branch 'exec-missing-validation' into 'master'
Add validation to check for missing files in exec() args
See merge request lab2425_autumn/pintos_22!36
|
2024-11-11 23:25:26 +00:00 |
|
EDiasAlberto
|
72afecfbda
|
Add validation to check for missing files in exec() args
|
2024-11-11 23:10:02 +00:00 |
|
Demetriades, Themis
|
9e692ced9e
|
Merge branch 'userprog-merge' into 'master'
Update variable references between conflicting merges to refer to the same...
See merge request lab2425_autumn/pintos_22!35
|
2024-11-11 22:59:45 +00:00 |
|
Demetriades, Themis
|
f194fa1fa8
|
Merge branch 'userprog-merge' into 'master'
Implement complete stack initialization, process_wait, and all system calls correctly except exec
See merge request lab2425_autumn/pintos_22!34
|
2024-11-11 22:56:28 +00:00 |
|
Themis Demetriades
|
e8713e26c6
|
Update variable references between conflicting merges to refer to the same data in stack initialization
|
2024-11-11 22:51:19 +00:00 |
|
Demetriades, Themis
|
47c3657b65
|
Merge branch 'process-wait' into 'userprog-merge'
Fix race-condition in process result (memory leak), fix infinite loop in donors_list
See merge request lab2425_autumn/pintos_22!33
|
2024-11-11 22:24:39 +00:00 |
|
Demetriades, Themis
|
4eafdf10ba
|
Merge branch 'read-only-exec' into 'userprog-merge'
Combine syscall code with final stack initialization code
See merge request lab2425_autumn/pintos_22!32
|
2024-11-11 22:23:20 +00:00 |
|
Themis Demetriades
|
14a4841772
|
Fix bug where size of file name buffer was less than maximum file name size
|
2024-11-11 22:13:10 +00:00 |
|
Themis Demetriades
|
52fdd47e0c
|
Fix race condition in the passing of data from thread executing process_execute to its child
|
2024-11-11 21:51:38 +00:00 |
|
Themis Demetriades
|
049fc5559c
|
Reformat stack initialization code to follow style for length and spacing
|
2024-11-11 21:20:53 +00:00 |
|
EDiasAlberto
|
98a5818406
|
add file_deny_write and file_allow_write to process creation and exiting to make executable read-only
|
2024-11-11 17:55:24 +00:00 |
|
|
|
18c884234d
|
Fix race-condition in process result (memory leak), fix infinite loop in donors_list
|
2024-11-11 17:35:49 +00:00 |
|
EDiasAlberto
|
5b1e4b561b
|
merge process-wait
|
2024-11-11 15:50:21 +00:00 |
|
Themis Demetriades
|
b8d358ecb2
|
Update stack initialization to handle overflow by allocating a second page for argument pointers
|
2024-11-11 13:13:21 +00:00 |
|
Themis Demetriades
|
8b2fc86b51
|
Refactor process_init_stack to reduce code duplication
|
2024-11-10 14:34:38 +00:00 |
|
