Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always release filesys_lock when checking if file is valid in process_execute

Browse Source
This commit is contained in:
Gleb Koval
2024-11-12 20:07:51 +00:00
parent d878dbc132
commit ca9d23edf9
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/userprog/process.c
View File

@@ -87,9 +87,10 @@ process_execute (const char *cmd)
might be necessary. */ might be necessary. */
lock_acquire (&filesys_lock); lock_acquire (&filesys_lock);
/* Validates that the current file to be executed is a valid file */ /* Validates that the current file to be executed is a valid file */
if (filesys_open (file_name) == NULL) bool valid_file = filesys_open (file_name) != NULL;
return TID_ERROR;
lock_release (&filesys_lock); lock_release (&filesys_lock);
if (!valid_file)
return TID_ERROR;
/* Create a new thread to execute the command, by initializing /* Create a new thread to execute the command, by initializing
it running the function 'start_process' with the appropriate it running the function 'start_process' with the appropriate