Imperial-MEng/pintos_22
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix: Insert pages in mmap as PAGE_MMAP instead of PAGE_FILE

Browse Source
This commit is contained in:
sBubshait
2024-12-06 15:54:46 +00:00
parent f64b92bbfa
commit 22f3b0950f
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/userprog/syscall.c
View File

@@ -461,10 +461,9 @@ syscall_mmap (int fd, void *addr)
/* Check and ensure that there is enough space in the user virtual memory to /* Check and ensure that there is enough space in the user virtual memory to
hold the entire file. */ hold the entire file. */
for (off_t ofs = 0; ofs < file_size; ofs += PGSIZE) for (off_t ofs = 0; ofs < file_size; ofs += PGSIZE)
{
if (page_get (thread_current (), addr + ofs) != NULL) if (page_get (thread_current (), addr + ofs) != NULL)
return MMAP_FAILURE; return MMAP_FAILURE;
}
/* Map the file data into the user virtual memory starting from addr. */ /* Map the file data into the user virtual memory starting from addr. */
for (off_t ofs = 0; ofs < file_size; ofs += PGSIZE) for (off_t ofs = 0; ofs < file_size; ofs += PGSIZE)
@@ -473,7 +472,7 @@ syscall_mmap (int fd, void *addr)
off_t zero_bytes = PGSIZE - read_bytes; off_t zero_bytes = PGSIZE - read_bytes;
if (page_insert_file (file, ofs, addr + ofs, read_bytes, zero_bytes, true, if (page_insert_file (file, ofs, addr + ofs, read_bytes, zero_bytes, true,
PAGE_FILE) == NULL) PAGE_MMAP) == NULL)
return MMAP_FAILURE; return MMAP_FAILURE;
} }
@@ -482,7 +481,6 @@ syscall_mmap (int fd, void *addr)
if (mmap == NULL) if (mmap == NULL)
return MMAP_FAILURE; return MMAP_FAILURE;
return mmap->mapping; return mmap->mapping;
} }